Repository navigation
Add checkboxes to allow for opt-out of default VPC, subnet - #3411
Open
charliepark wants to merge 4 commits into
Open
charliepark wants to merge 4 commits into
charliepark wants to merge 4 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
Made the info box conditional: |
fakemonster
reviewed
Oct 20, 2026
| <CheckboxField name="createDefaultSubnet" control={form.control}> | ||
| Create default subnet | ||
| </CheckboxField> | ||
| {!createDefaultSubnet && ( |
Contributor
There was a problem hiding this comment.
i think this info message is a good level of heads up, but since you mentioned alternative display ideas, i'll just also throw out the idea of having an info i next to the checkbox that explains why we would think to generate a default "resource x" for you
Collaborator
There was a problem hiding this comment.
Yeah, I am kinda leaning tooltip, if only so you don’t have to uncheck the box to get the info. Also it could have a second sentence and it wouldn’t feel like it was taking up so much space.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds checkboxes to two places in the Console UI, one during Project create, one during VPC create. These allow a user to opt out of creating the default VPC (during Project creation) or the default subnet (during VPC creation).
(I'm open to other treatments for that help text than that information box. As it is, it makes it look like something is missing. We could have the information box only show up when the checkbox is unchecked?)
This is the Console part of some earlier changes, with Omicron issue oxidecomputer/omicron#10973 and relevant PR oxidecomputer/omicron#9750.
Closes #3375
Todo: will need to update the screenshot at https://docs.oxide.computer/guides/onboarding-projects once merged