Repository navigation
Don't preventDefault on Enter in Combobox if unhandled - #3417
Open
fakemonster wants to merge 1 commit into
Open
fakemonster wants to merge 1 commit into
fakemonster wants to merge 1 commit into
Conversation
Previously, by unconditionally preventing default on Enter presses in the Combobox, it was impossible to submit a form by hitting enter while focused in a (closed) Combobox. A user would reasonably expect that pressing Enter while it was closed, much like a regular text field, would submit the form they were in. In practice this means a keyboard user is going to navigate to the combobox, find their selection, and hit enter twice: once to close the selection and again to submit the form.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
@charliepark this is what i was getting at in response to your comment here; propagating enter presses from the combobox is a more general change (if fairly simple) |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, by unconditionally preventing default on Enter presses in the Combobox, it was impossible to submit a form by hitting enter while focused in a (closed) Combobox. A user would reasonably expect that pressing Enter while it was closed, much like a regular text field, would submit the form they were in.
In practice this means a keyboard user is going to navigate to the combobox, find their selection, and hit enter twice: once to close the selection and again to submit the form.