Add support for a new StreamingBody extractor#617
Merged
sunshowers merged 4 commits intomainfrom Mar 24, 2023
Merged
Conversation
Created using spr 1.3.4
Created using spr 1.3.4
This was referenced Mar 21, 2023
Created using spr 1.3.4
davepacheco
approved these changes
Mar 24, 2023
sunshowers
deleted the
sunshowers/spr/add-support-for-a-new-streamingbody-extractor
branch
sunshowers
added a commit
that referenced
this pull request
Nov 21, 2024
For some endpoints like uploading update and support bundles, we would like to have a larger request limit. Add support for that. This is the other half of RFD 353, after #617. (A previous attempt was #618, which I've abandoned.) The PR consists of: * The implementation. * A small tweak to the API generation code for better span attribution. * Tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per RFD 353, add support for a new extractor that can provide data as a
stream of Bytes chunks. This means that large request payloads won't
have to buffer everything into a single, contiguous chunk of memory.
Also add some examples showing how to use the extractor to operate on
chunks in a streaming fashion. (There are also other potential examples
we can add here, such as compressing and/or decompressing data on the
fly). I haven't implemented those here.
Finally, switch over the other extractors to be implemented on top of
StreamingBody. In effect, the other extractors just provide adifferently-shaped API on top of
StreamingBody.This PR doesn't implement support for the other determination in RFD
353, which is to allow some endpoints' max payload sizes to be set to a
higher limit. That's in #618.