Add downloaded blobs to package tarball#75
Merged
pfmooney merged 1 commit intooxidecomputer:mainfrom Apr 17, 2025
Merged
Conversation
smklein
approved these changes
Apr 17, 2025
Collaborator
smklein
left a comment
There was a problem hiding this comment.
Ah, thanks for patching this!
Contributor
Author
Testing notesTarball contents for propolis-server (using omicron-zone-package 0.12) prior to this change: And using a cargo-patched version with the change: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While updating propolis to from its quite old (0.9) version of omicron-zone-package, I noticed that the S3 blobs included in its manifest were being downloaded but not appended to the archive. It appears that such functionality was disrupted as part of the overhaul in #60.
This should restore blob inclusion in the package.