Skip to content

fix: add missing operation_id to versioned API endpoints #9770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sudomateo merged 1 commit into from
Feb 2, 2026
Merged

fix: add missing operation_id to versioned API endpoints #9770

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion nexus/external-api/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1992,6 +1992,7 @@ pub trait NexusExternalApi {
/// Deprecated: Groups are created implicitly when adding members in newer
/// API versions.
#[endpoint {
operation_id = "multicast_group_create",
method = POST,
path = "/v1/multicast-groups",
tags = ["experimental"],
Expand Down Expand Up @@ -2051,6 +2052,7 @@ pub trait NexusExternalApi {
///
/// Deprecated: groups are managed implicitly through member operations.
#[endpoint {
operation_id = "multicast_group_update",
method = PUT,
path = "/v1/multicast-groups/{multicast_group}",
tags = ["experimental"],
Expand All @@ -2074,6 +2076,7 @@ pub trait NexusExternalApi {
///
/// Deprecated: groups are deleted automatically when the last member leaves.
#[endpoint {
operation_id = "multicast_group_delete",
method = DELETE,
path = "/v1/multicast-groups/{multicast_group}",
tags = ["experimental"],
Expand Down Expand Up @@ -2192,6 +2195,7 @@ pub trait NexusExternalApi {
///
/// Deprecated: use the main view endpoint which accepts IP addresses directly.
#[endpoint {
operation_id = "lookup_multicast_group_by_ip",
method = GET,
path = "/v1/system/multicast-groups/by-ip/{address}",
tags = ["experimental"],
Expand Down Expand Up @@ -2290,6 +2294,7 @@ pub trait NexusExternalApi {
// TODO-correctness See note about instance create. This should be async.
/// Create disk
#[endpoint {
operation_id = "disk_create",
method = POST,
path = "/v1/disks",
tags = ["disks"],
Expand All @@ -2308,6 +2313,7 @@ pub trait NexusExternalApi {
// TODO-correctness See note about instance create. This should be async.
/// Create disk
#[endpoint {
operation_id = "disk_create",
method = POST,
path = "/v1/disks",
tags = ["disks"],
Expand Down Expand Up @@ -2355,6 +2361,7 @@ pub trait NexusExternalApi {

/// Fetch disk
#[endpoint {
operation_id = "disk_view",
method = GET,
path = "/v1/disks/{disk}",
tags = ["disks"],
Expand Down Expand Up @@ -2465,7 +2472,7 @@ pub trait NexusExternalApi {

/// Create instance
#[endpoint {
operation_id = "disk_create",
operation_id = "instance_create",
method = POST,
path = "/v1/instances",
tags = ["instances"],
Expand Down Expand Up @@ -2559,6 +2566,7 @@ pub trait NexusExternalApi {

/// Create instance
#[endpoint {
operation_id = "instance_create",
method = POST,
path = "/v1/instances",
tags = ["instances"],
Expand All @@ -2574,6 +2582,7 @@ pub trait NexusExternalApi {
}

#[endpoint {
operation_id = "instance_create",
method = POST,
path = "/v1/instances",
tags = ["instances"],
Expand Down Expand Up @@ -2627,6 +2636,7 @@ pub trait NexusExternalApi {

/// Update instance
#[endpoint {
operation_id = "instance_update",
method = PUT,
path = "/v1/instances/{instance}",
tags = ["instances"],
Expand Down Expand Up @@ -2771,6 +2781,7 @@ pub trait NexusExternalApi {

/// List disks for instance
#[endpoint {
operation_id = "instance_disk_list",
method = GET,
path = "/v1/instances/{instance}/disks",
tags = ["instances"],
Expand Down Expand Up @@ -2833,6 +2844,7 @@ pub trait NexusExternalApi {

/// Attach disk to instance
#[endpoint {
operation_id = "instance_disk_attach",
method = POST,
path = "/v1/instances/{instance}/disks/attach",
tags = ["instances"],
Expand Down Expand Up @@ -2894,6 +2906,7 @@ pub trait NexusExternalApi {

/// Detach disk from instance
#[endpoint {
operation_id = "instance_disk_detach",
method = POST,
path = "/v1/instances/{instance}/disks/detach",
tags = ["instances"],
Expand Down Expand Up @@ -3482,6 +3495,7 @@ pub trait NexusExternalApi {
) -> Result<HttpResponseOk<ResultsPage<BgpConfig>>, HttpError>;

#[endpoint {
operation_id = "networking_bgp_status",
method = GET,
path = "/v1/system/networking/bgp-status",
tags = ["system/networking"],
Expand Down Expand Up @@ -4046,6 +4060,7 @@ pub trait NexusExternalApi {

/// Detach and deallocate ephemeral IP from instance
#[endpoint {
operation_id = "instance_ephemeral_ip_detach",
method = DELETE,
path = "/v1/instances/{instance}/external-ips/ephemeral",
tags = ["instances"],
Expand Down
Loading