propolis-mock-server should expose more types#808
Merged
davepacheco merged 4 commits intomasterfrom Nov 13, 2024
Merged
Conversation
gjcolombo
approved these changes
Nov 13, 2024
Contributor
gjcolombo
left a comment
gjcolombo
left a comment
There was a problem hiding this comment.
LGTM, provided it fixes things up in Omicron. Picking up this change there and running cargo nextest should verify that things are still working.
Comment on lines
+657
to
+660
| /// | ||
| /// This function should be avoided in favor of `start()` because using this | ||
| /// function requires that the consumer and Propolis update Dropshot | ||
| /// dependencies in lockstep due to the sharing of various types. |
Contributor
There was a problem hiding this comment.
Should we just remove the pub instead? AFAIK (from a global GitHub search) the only user of this crate who calls this is simulated sled agent, which is presumably the consumer we want to switch to using start.
Contributor
Author
There was a problem hiding this comment.
I'm happy to do that but would prefer to do it in a separate PR to minimize the chance of breakage on the critical path here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See oxidecomputer/omicron#3361.
Tested via oxidecomputer/omicron#7057.