Added duplicate selection (CTRL+D), undo and redo (CTRL+Z/Y) with scene history. - #133
Open
ReubenJCarter wants to merge 53 commits into
Open
ReubenJCarter wants to merge 53 commits into
ReubenJCarter wants to merge 53 commits into
Conversation
added 9 commits
November 8, 2017 17:34
…odes as the performance was bad. Added OpenGL rendering for flow view.
…hat have no endpoint on selection
… data model to nodes when duplicating
Owner
|
My laptop is in repair and I was busy with our small baby last weeks. Thanks |
… performance benefits
# Conflicts: # src/FlowView.cpp # src/FlowView.hpp
Daguerreo
suggested changes
Apr 19, 2019
Daguerreo
left a comment
Daguerreo
left a comment
There was a problem hiding this comment.
Indenting is not consistent with the project. Copy and Pasting a node from a scene to another should not throw in case the node is not registered in second scene but just not performing the operation.
Daguerreo
reviewed
Apr 19, 2019
| virtual | ||
| NodePainterDelegate* painterDelegate() const { return nullptr; } | ||
|
|
||
| QString toolTipText(); |
There was a problem hiding this comment.
Should be const and inline as other getters
| } | ||
|
|
||
|
|
||
| void NodeDataModel::setToolTipText(QString text) |
|
|
||
| Node&restoreNode(QJsonObject const& nodeJson); | ||
|
|
||
| QUuid pasteNode(QJsonObject &json); |
| _scene->UpdateHistory(); | ||
| } | ||
|
|
||
| void FlowView::duplicateSelectedNode() |
There was a problem hiding this comment.
a lot of implicit conversion warning float-double
|
|
||
| //create nodes | ||
| std::vector<Node*> createdNodes; | ||
| std::vector<Node*> couterpartNode; |
|
|
||
| void FlowScene::pasteConnection(QJsonObject const &connectionJson, QUuid newIn, QUuid newOut) | ||
| { | ||
| QUuid nodeInId = QUuid(connectionJson["in_id"].toString()); |
| if(j >=0 && k>=0 && j < couterpartNode.size() && k < couterpartNode.size()) | ||
| { | ||
| auto connection = _scene->createConnection(*createdNodes[j], portIndexIn, *createdNodes[k], portIndexOut); | ||
| auto& connectionRef = connection; |
Owner
|
This pull request has a plenty of unrelated features. Nevertheless, I took some coding samples from this work and implemented an Undo/Redo system and a Ctrl+D node duplication mechanism. I'll continlue looking through the code to take more features for master |
Added logic to avoid saving duplicate connections when serializing the scene and when exporting selected nodes and connections. This ensures that each connection is only included once in the resulting JSON, improving data integrity and preventing redundant entries.
contextMenuEvent was an empty stub, so a group's colour could only be set by editing the saved JSON. The colour is stored in r/g/b, which Group::save() already writes. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
FlowView::setNavigation(blender, trackpadScroll), default Blender + trackpad: middle-drag or Alt+left-drag pans, Ctrl+that zooms, left-drag on empty space box-selects, Home frames all nodes; trackpad scroll pans and Ctrl+scroll (pinch) zooms at the cursor, or the wheel zooms in mouse mode. blender=false keeps the original left-drag pan / wheel step zoom. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…p under the mouse Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
- Drawing mode: auto (software over Remote Desktop, where OpenGL falls back to slow software GL), OpenGL, or software; software repaints only what changed. - Low detail below 40% zoom: embedded widgets hidden. - Anti-aliasing off while panning/zooming, back on 150 ms after. - Optional frame-time overlay to measure (ms/frame, mode, node count). - Group collapse button: hamburger icon, always top-left; name keeps clear. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Zoom no longer scales with the trackpad pan speed and each step is capped at one notch (1.1x at zoom speed 1), so coarse Ctrl+scroll/pinch steps over RDP don't jump. Pan speed default 4. The frame-time overlay also shows the last raw wheel event (angle/pixel delta, modifier) to tune against. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Zoom felt slow/jumpy: every step jumped to the new scale and forced every visible node to re-render its DeviceCoordinateCache at the new zoom level. Wheel/pinch zoom now accumulates a target (1.2x per notch at zoom speed 1, at most ~3 notches queued) and eases towards it at 60 fps; while zooming, nodes use ItemCoordinateCache (scaled pixmap) and return to the crisp device cache 150 ms after the last step. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Groups: colour/collapse menu, Blender-style navigation, faster drawing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.