Skip to content

BUGFIX: GraphicsView::setScene(nullptr) #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paceholder merged 2 commits into from
Nov 14, 2025
Merged

BUGFIX: GraphicsView::setScene(nullptr) #495

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d870345
BUGFIX: GraphicsView::setScene(nullptr)
cxxamz Oct 30, 2025
91fd551
Make revisions based on the review results.
cxxamz Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 28 additions & 1 deletion src/GraphicsView.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,21 @@ QAction *GraphicsView::deleteSelectionAction() const
void GraphicsView::setScene(BasicGraphicsScene *scene)
{
QGraphicsView::setScene(scene);
if (!scene)
{
// Clear actions.
delete _clearSelectionAction;
delete _deleteSelectionAction;
delete _duplicateSelectionAction;
delete _copySelectionAction;
delete _pasteAction;
_clearSelectionAction = nullptr;
_deleteSelectionAction = nullptr;
_duplicateSelectionAction = nullptr;
_copySelectionAction = nullptr;
_pasteAction = nullptr;
return;
}

{
// setup actions
Expand Down Expand Up @@ -171,6 +186,8 @@ void GraphicsView::contextMenuEvent(QContextMenuEvent *event)
return;
}

if (!nodeScene()) return;

auto const scenePos = mapToScene(event->pos());

QMenu *menu = nodeScene()->createSceneMenu(scenePos);
Expand Down Expand Up @@ -274,12 +291,15 @@ void GraphicsView::setupScale(double scale)

void GraphicsView::onDeleteSelectedObjects()
{
if (!nodeScene()) return;

nodeScene()->undoStack().push(new DeleteCommand(nodeScene()));
}

void GraphicsView::onDuplicateSelectedObjects()
{
qDebug() << "ON DUPLICATE";
if (!nodeScene()) return;

QPointF const pastePosition = scenePastePosition();

nodeScene()->undoStack().push(new CopyCommand(nodeScene()));
Expand All @@ -288,11 +308,15 @@ void GraphicsView::onDuplicateSelectedObjects()

void GraphicsView::onCopySelectedObjects()
{
if (!nodeScene()) return;

nodeScene()->undoStack().push(new CopyCommand(nodeScene()));
}

void GraphicsView::onPasteObjects()
{
if (!nodeScene()) return;

QPointF const pastePosition = scenePastePosition();
nodeScene()->undoStack().push(new PasteCommand(nodeScene(), pastePosition));
}
Expand Down Expand Up @@ -335,6 +359,9 @@ void GraphicsView::mousePressEvent(QMouseEvent *event)
void GraphicsView::mouseMoveEvent(QMouseEvent *event)
{
QGraphicsView::mouseMoveEvent(event);

if (!scene()) return;

if (scene()->mouseGrabberItem() == nullptr && event->buttons() == Qt::LeftButton) {
// Make sure shift is not being pressed
if ((event->modifiers() & Qt::ShiftModifier) == 0) {
Expand Down
Loading