PACKIT-5037: Enable Packit CI#627
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Packit target environments to fedora-latest-stable and adds an encrypted GITLAB_CI_TOKEN to the Testing Farm configuration. The reviewer noted that the GITLAB_CI_TOKEN secret is incorrectly formatted as a list, which will cause Testing Farm to fail to parse the configuration or break the git clone command. It should be defined as a single string instead.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| GITLAB_CI_TOKEN: | ||
| # TODO automated for `main` | ||
| # mfocko | ||
| - "ea2a89aa-6a78-40e0-906e-140f623c45b0,Pk5X+XenyDxsMNgX/k/lIehht6kSOi/vBQR8Hm0X8Q5KDcyTcTXk3LgFDQWeoeb3X214aIMmmVHxo0t2UUDhg1S7Yv5pA86oounM+1K2KWoatjpBbn2pK/0G3IkRCxibkm+JJVeBtXzgk3vdTF1SpoQg0IWt708nzmedjjk/1uHoZVG6SW8yv2O3IPS7jZwXK3IUJEA1e3LkhvjN0i8fIlVNwyBRRyMEjF63MbObfvcyylDcc4MRhi+tP+DW45WyVAa5mZoz2OIHosG+7cHQ4ywbpzyGOU+Gqj7/gJpRxntXn+BaM/VHeshy/RUoimwhYUbvhl+XGGmMCyP4jFl3OWyS6ptMlSc9n2vuObZMl5TlRc4nmYE4kgO9pVdE8NvMKsRWqT4djVPm094gYAJNVJmUEmh/AoTLgVxI/WoxxuSTAli1pxz3mC663ChG0WAjOlonCdGGzPttpuKZtrsvHloi66V9cJ3p8Gq3r7waDoL5Hs4h2OJ1tqfMlLv7+Q3UEqziZVdpn+XTPUtay67RcYODrF2XzN4BjFMVY5VteMnmNRqUxy0U0G3rXgA+ftVidLb2YG1S0YvR6DMClpfZpSaSVYgBKJc3VP4tTY6H5Tdii9qYcY63h//1i2lZkC/Aa/0ec6XjDYx4UE+d397b0tx08XpaNf8Mx/01AI5zqyY=" |
There was a problem hiding this comment.
In Testing Farm, secrets must be defined as key-value pairs where the value is a single string. Defining GITLAB_CI_TOKEN as a list (using -) will cause Testing Farm to either fail to parse the configuration or inject the token as a stringified list (e.g., ["ea2a89aa..."]). This will break the git clone command in plans/triage-e2e.fmf which expects a plain token string.
GITLAB_CI_TOKEN: "ea2a89aa-6a78-40e0-906e-140f623c45b0,Pk5X+XenyDxsMNgX/k/lIehht6kSOi/vBQR8Hm0X8Q5KDcyTcTXk3LgFDQWeoeb3X214aIMmmVHxo0t2UUDhg1S7Yv5pA86oounM+1K2KWoatjpBbn2pK/0G3IkRCxibkm+JJVeBtXzgk3vdTF1SpoQg0IWt708nzmedjjk/1uHoZVG6SW8yv2O3IPS7jZwXK3IUJEA1e3LkhvjN0i8fIlVNwyBRRyMEjF63MbObfvcyylDcc4MRhi+tP+DW45WyVAa5mZoz2OIHosG+7cHQ4ywbpzyGOU+Gqj7/gJpRxntXn+BaM/VHeshy/RUoimwhYUbvhl+XGGmMCyP4jFl3OWyS6ptMlSc9n2vuObZMl5TlRc4nmYE4kgO9pVdE8NvMKsRWqT4djVPm094gYAJNVJmUEmh/AoTLgVxI/WoxxuSTAli1pxz3mC663ChG0WAjOlonCdGGzPttpuKZtrsvHloi66V9cJ3p8Gq3r7waDoL5Hs4h2OJ1tqfMlLv7+Q3UEqziZVdpn+XTPUtay67RcYODrF2XzN4BjFMVY5VteMnmNRqUxy0U0G3rXgA+ftVidLb2YG1S0YvR6DMClpfZpSaSVYgBKJc3VP4tTY6H5Tdii9qYcY63h//1i2lZkC/Aa/0ec6XjDYx4UE+d397b0tx08XpaNf8Mx/01AI5zqyY="
mfocko
force-pushed
the
ci/enable-packit
branch
5 times, most recently
from
3168d6f to
fd72f09
Compare
|
/packit test |
So that's where the mocks and secrets went… |
mfocko
force-pushed
the
ci/enable-packit
branch
7 times, most recently
from
3c3c9ec to
ef9ef34
Compare
|
/packit test |
mfocko
force-pushed
the
ci/enable-packit
branch
11 times, most recently
from
e0c4ea9 to
380ee68
Compare
Signed-off-by: Matej Focko <mfocko@packit.dev>
After trying to run the pipeline, I've noticed that CentOS is missing podman-compose. After a brief chat with @TomasKorbar, it should be OK to run on the latest Fedora. Signed-off-by: Matej Focko <mfocko@packit.dev>
Tags have to be KV pairs. Signed-off-by: Matej Focko <mfocko@packit.dev>
Signed-off-by: Matej Focko <mfocko@packit.dev>
Signed-off-by: Matej Focko <mfocko@packit.dev>
Looking at the docs, it appears that the only files that are guaranteed
to be persistent are saved within the $TMT_PLAN_DATA directory, therefore
move the prepped data there and move them back before the test starts.
Excerpt from the docs:
If you want to use the prepare step to generate data files needed for
testing during the execute step, move or copy them into
${TMT_PLAN_DATA} directory. Only files in this directory are
guaranteed to be preserved.
Signed-off-by: Matej Focko <mfocko@packit.dev>
Signed-off-by: Matej Focko <mfocko@packit.dev>
Signed-off-by: Matej Focko <mfocko@packit.dev>
Signed-off-by: Matej Focko <mfocko@packit.dev>
Signed-off-by: Matej Focko <mfocko@packit.dev>
Signed-off-by: Matej Focko <mfocko@packit.dev>
Signed-off-by: Matej Focko <mfocko@packit.dev>
1 participant
TODO