fix(api): use web login for e-Connect to register the client for long-polling#161
Merged
fix(api): use web login for e-Connect to register the client for long-polling#161
Conversation
Pull Request Test Coverage Report for Build 14430103988Details
💛 - Coveralls |
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
This change (re)introduces the web page login when e-Connect alarm system is used. This is required as it seems the public API doesn't register the client to get updates from the long-polling API.
We introduce also
tests/scripts/debug_polling.pydebug script to verify if long-polling is working or not in a real world scenario.Testing:
Use
tests/scripts/debug_polling.pyto see if long polling works in your scenario.Extra Notes (optional):
This is a temporary change as it looks like Elmo is making updates to the Cloud API. As soon as a new public and documented API is out, we'll probably drop this approach in favor of something more reliable.
Checklist