Fixed write_usage producing empty output when args is empty.#3413
Closed
tejasae-afk wants to merge 1 commit into
Closed
Fixed write_usage producing empty output when args is empty.#3413tejasae-afk wants to merge 1 commit into
tejasae-afk wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3360.
When
HelpFormatter.write_usageis called with noargs(or an empty string), the usage line was silently dropped. The call towrap_text("", ...)returned an empty string, so only the trailing\nwas written to the buffer.Root cause:
wrap_textwith an empty text string returns"", writing nothing. Theusage_prefix(e.g."Usage: program ") was only passed as theinitial_indenttowrap_text, not written directly.Fix: Short-circuit when
argsis empty — writeusage_prefix(stripped of its trailing space) directly and skipwrap_textentirely.Before:
After:
Test added in
tests/test_formatting.py. Full suite: 1494 passed, 24 skipped.