-
-
Notifications
You must be signed in to change notification settings - Fork 19.4k
ENH: Fixing some types #63226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
ENH: Fixing some types #63226
Conversation
rhshadrach
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Improving the type-hints would certainly be welcome, but it seems the changes here are either incorrect or equivalent to the type-hints that are already there.
| *, | ||
| header: int | Sequence[int] | None = ..., | ||
| names: SequenceNotStr[Hashable] | range | None = ..., | ||
| index_col: int | str | Sequence[int] | None = ..., |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing str here is incorrect, index_col can be a string.
|
@rhshadrach Thanks for having looked at it! |
Ah, with pyright but not mypy, sure. But in either case I'm not really seeing a benefit to adding |
Fixing some types