You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
test: give the package tests a 20 s timeout on Windows - #486
The same tests take under 100 ms on Linux, and the #475 run passed on a re-run. The Windows runner is just slow at a full setup, and those tests sit right at the 5 s default. This sets testTimeout to 20 s on win32 only. Linux keeps 5 s, so a real hang still fails fast there.
The Windows runner timed out twice today on Analog tests that run a full
devframe setup (analog-server-fns, analog-page-calls), while the same tests
take under 100 ms on Linux and pass on a rerun. Raise the per-test timeout
on win32 only, so slow setups there no longer fail the job and Linux keeps
the 5 s default that catches real hangs.
The timeout change is mergeable after normal checks.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title "test: give the package tests a 20 s timeout on Windows" matches the single change in the changeset. The raw summary shows packages/devtools/vitest.config.ts sets testTimeout to 20 seconds o…
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title "test: give the package tests a 20 s timeout on Windows" matches the single change in the changeset. The raw summary shows packages/devtools/vitest.config.ts sets testTimeout to 20 seconds on Windows and 5 seconds elsewhere. The PR objectives confirm the purpose: Windows CI timed out on Analog tests, and the Linux 5-second default is kept. The title names the platform, the value, and the target. It is specific and accurate. Minor point: the change touches only the devtools package config, and the title says "the package tests", which is slightly broader than the one file, but this does not make it misleading.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: a493da09-33aa-4612-8921-c3b1970ef524
Commits
Reviewing files that changed from the base of the PR and between 7e5f0ef and b699b71.
Files selected for processing: 1
packages/devtools/vitest.config.ts
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
"Workers Builds: angular-devtools" fails on every PR right now because of a Cloudflare dashboard setting (#431, tracked in #482). It isn't caused by this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
Bot
added
the
area: package
What and why
Refs #373. "Package tests on Windows" timed out twice today, on two different PRs, both times in Analog tests that run a full devframe setup:
analog-server-fns, on feat(injectors): refresh, inactive lazy injectors, unresolved helpers and provider hints #475;analog-page-calls, two tests, on feat(ui): Filter field, splitters, counts pill, buildReport() and extension popup and sidebar #483.The same tests take under 100 ms on Linux, and the #475 run passed on a re-run. The Windows runner is just slow at a full setup, and those tests sit right at the 5 s default. This sets
testTimeoutto 20 s onwin32only. Linux keeps 5 s, so a real hang still fails fast there.No test is skipped or changed.
How it was verified
prettier --checkon the configpnpm commit:checkGenerated by Claude Code
Summary by CodeRabbit