Feature/p3i cec overhaul#70
Open
swmarks wants to merge 1 commit into
Open
Conversation
56749ca to
1306471
Compare
Contributor
|
is this compatible with my PR or does one of ours need re-working? |
1306471 to
707bf0f
Compare
Author
Yep, this PR exists in parallel with yours. I think it could possibly be merged without yours, but I don't see any reason to do that. I tested with your commits applied. |
707bf0f to
8bb4d11
Compare
Contributor
|
Maybe it's just me, but at this point I feel like this should be an actual code change rather than a patch. Correct me if I'm wrong, but aren't patches generally intended for small fixes, rather than adding this many lines all of code at once? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a patch for Kodi that fixes several CEC routing bugs and reorganizes the CEC settings UI.
CEC Logic Fixes:
CPeripheralCecAdapter. Previously, Kodi only went into standby if the command explicitly originated fromCECDEVICE_TV. We expanded this logic to also triggerOnTvStandbyif the standby command was destined forCECDEVICE_TVorCECDEVICE_BROADCAST./run/kodi_cec_startup_done. The reasoning behind this implementation is to maintain a persistent active source variable that survives through Kodi crashes or restarts. Kodi now reliably knows if it is actually the active source on the TV before it blindly issues CEC wakeup or shutdown commands.OnPlayfrom the startup broadcast setting, and tied it to a newly renamed "Switch source to this device on activity" setting.OnActionPreCEC remote events while the screensaver is active, ensuring stray remote keypresses don't artificially trigger the CEC spam throttle and block the screensaver from properly waking the TV upon dismissal.UI Overhaul:
Peripherals.cppthat was preventing settings from displaying in the correct order. This bug likely would have affected any peripheral service that happened to be available, not just CEC.Note: This PR also removes
kodi-999.15-disable-using-tv-menu-language-by-default.patch, as the massive UI overhaul ofsystem/peripherals.xmlnatively incorporates theuse_tv_menu_languagedefault value change and completely reorganizes the file layout, rendering 999.15 obsolete and a source of hard conflicts.