Skip to content

馃敡 fix: go vet check now actually works - #32

Merged
jpmcb merged 1 commit into
mainfrom
fix-go-vet
Aug 10, 2026
Merged

馃敡 fix: go vet check now actually works#32
jpmcb merged 1 commit into
mainfrom
fix-go-vet

Conversation

@jpmcb

@jpmcb jpmcb commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Gets the go vet check to actually work via go vet ./... - also adds some fixture checks for the go module

Refs PCC-1166

@greptile-apps

greptile-apps Bot commented Aug 10, 2026

Copy link
Copy Markdown

Greptile Summary

The PR broadens the Go vet check to inspect every package under the supplied module and adds a minimal fixture-based Make target for exercising the Go checks.

  • Changes CheckGoVet to execute go vet ./....
  • Adds a fixture Go module and Make target covering module-tidiness and vet checks.
  • Refreshes several direct and indirect Go dependencies and their checksums.

Confidence Score: 5/5

The PR appears safe to merge, with no concrete changed-code failures identified.

The expanded vet command runs from the mounted module root and covers nested packages, while the new fixture provides a valid module for both checks; investigated dependency advisories either predate this PR or have no reachable affected path in repository code.

Important Files Changed

Filename Overview
go/main.go Updates the vet invocation to cover all packages under the mounted source module; no actionable defect was identified.
go/Makefile Adds fixture commands for exercising both Go module tidiness and vet checks.
go/fixtures/go.mod Defines the minimal Go 1.26 fixture module used by the new Make target.
go/go.mod Refreshes dependency versions without introducing a reachable compatibility or security defect identified in this review.

Reviews (1): Last reviewed commit: "馃敡 fix: go vet check now actually works" | Re-trigger Greptile

@linear-code

linear-code Bot commented Aug 10, 2026

Copy link
Copy Markdown

PCC-1166

Signed-off-by: John McBride <john@papercompute.com>
@jpmcb
jpmcb merged commit a0c7277 into main Aug 10, 2026
7 checks passed
@jpmcb
jpmcb deleted the fix-go-vet branch August 10, 2026 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant