✨ feat: Dockerimage module for unified builds - #33
Conversation
|
| Filename | Overview |
|---|---|
| .github/workflows/pr.yaml | Adds Docker image CI, but executes checked-out pull-request code with a repository token and retains previously reported mutable action references. |
| dockerimage/main.go | Implements configurable Dockerfile builds and sequential multi-platform publication for each requested tag. |
| dockerimage/Makefile | Adds amd64 and arm64 fixture builds and forms part of the pull-request-controlled command path receiving the CI credential. |
| dockerimage/go.mod | Defines the generated Dagger module's Go dependencies and compatibility replacements. |
| dockerimage/fixtures/Dockerfile | Provides a build-only fixture that verifies build-argument propagation. |
Sequence Diagram
sequenceDiagram
participant PR as Pull request
participant CI as GitHub Actions
participant Build as PR-controlled build code
participant Cloud as External endpoint
PR->>CI: Trigger pull_request workflow
CI->>CI: Checkout proposed changes
CI->>Build: Run make test with DAGGER_CLOUD_TOKEN
Build-->>Cloud: Token can be transmitted
Prompt To Fix All With AI
### Issue 1
.github/workflows/pr.yaml:36
**PR code receives repository token**
If same-repository pull requests receive `DAGGER_CLOUD_TOKEN`, this job checks out the proposed changes and runs their Makefile, Nix environment, Dagger module, and Dockerfile with that credential, allowing the pull-request author to transmit the token. **How this was verified:** The `pull_request` job executes `make -C dockerimage test` from the checked-out changes with `DAGGER_CLOUD_TOKEN` in its environment.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (2): Last reviewed commit: "✨ feat: Dockerimage module for unified b..." | Re-trigger Greptile
Signed-off-by: John McBride <john@papercompute.com>
| - name: Test image builds | ||
| run: nix develop --command make -C dockerimage test | ||
| env: | ||
| DAGGER_CLOUD_TOKEN: ${{ secrets.DAGGER_CLOUD_TOKEN }} |
There was a problem hiding this comment.
PR code receives repository token
If same-repository pull requests receive DAGGER_CLOUD_TOKEN, this job checks out the proposed changes and runs their Makefile, Nix environment, Dagger module, and Dockerfile with that credential, allowing the pull-request author to transmit the token. How this was verified: The pull_request job executes make -C dockerimage test from the checked-out changes with DAGGER_CLOUD_TOKEN in its environment.
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/pr.yaml
Line: 36
Comment:
**PR code receives repository token**
If same-repository pull requests receive `DAGGER_CLOUD_TOKEN`, this job checks out the proposed changes and runs their Makefile, Nix environment, Dagger module, and Dockerfile with that credential, allowing the pull-request author to transmit the token. **How this was verified:** The `pull_request` job executes `make -C dockerimage test` from the checked-out changes with `DAGGER_CLOUD_TOKEN` in its environment.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.There was a problem hiding this comment.
This is fine and a pattern we have throughout the papercomputeco org: "same-repository pull requests" are from only internal, trusted contributors (i.e., employees).
Build automation for docker image based builds / releases. Much of this is already covered in papercomputeco/tapes and should get hoisted here.
Refs PCC-1166