Rename task_data to environment_data in tests, examples, and docs#58
Merged
Rename task_data to environment_data in tests, examples, and docs#58
Conversation
… variables Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…a dict
The old code wrapped task.environment_data in {"environment_data": ...},
causing setup_state to silently get tools=[] via .get("tools", []).
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Eliminates confusing
task_datanaming in tests and examples where the value is actuallyenvironment_data. The production code (base class + all 6 environments + all benchmark instantiations) already usesenvironment_dataconsistently — this PR fixes tests, fixtures, and examples that still used the old naming.Also fixes a bug in MACS real_data tests where
{"environment_data": task.environment_data}wrapped environment_data in an extra dict, causingsetup_stateto silently gettools=[]via.get("tools", []).Type of Change
Checklist
Contribution
Documentation
docs/(if applicable)Changelog
CHANGELOG.mdunder[Unreleased]sectionArchitecture (if applicable)
maseval/core/do NOT import frommaseval/interface/Additional Notes
just allcleantask_datareferences in multiagentbench are intentional (refers to the"task"sub-field of environment_data, a different concept)