chore(cli): code cleanup

[sphamjoli]

Description

This PR cleansup some dead code and minor fixes to the escrow views in the cli and ui

Type

• Bug fix
• Feature
• Breaking change
• Documentation
• Chore

Package

• @parity/dotns-cli
• Root/monorepo
• Documentation

Related Issues

Fixes

Checklist

Code

• Follows project style
• bun run lint passes
• bun run format passes
• bun run typecheck passes

Documentation

• README updated if needed
• Types updated if needed

Breaking Changes

• No breaking changes
• Breaking changes documented below

Breaking changes:

Testing

How to test:

Notes

[github-actions]

CI Summary

Check	Result
Lint (UI)	Passed
Format	Passed
Format (UI)	Passed
Typecheck	Passed
Typecheck (UI)	Passed
Build	Passed
Build (UI)	Passed
Release	Passed
Deploy UI	Failed
Deploy Example	Passed
Benchmark UI	Passed
PR Title	Passed
Labels	Passed
Test	Passed - 231 passed, 0 failed

---

Release - Passed

Test this PR

Download artifact (GitHub CLI required):

gh run download 27405488066 -n cli-release-0.0.0-pr.178 -R paritytech/dotns-sdk

Install globally:

npm install -g ./parity-dotns-cli-0.0.0-pr.178.tgz

Verify:

dotns --help

Deploy UI — Failed

Failed at: Deploy — Deploy workflow failed — see run logs for upload/register/contenthash details

Stage	Status
✓ Build	Build succeeded
✗ Deploy	Deploy workflow failed — see run logs for upload/register/contenthash details

View run

Deploy Example — Passed

Stage	Status
✓ Site validation	Site validated
✓ Deploy	Deployed (cached)

Property	Value
Domain	pr178.dotns-example-site.dot
CID	bafybeicx555prsudvmqsdrap7keoilryrudwycdx3ody2rejwqwjwp52u4 (cached)
URL (dot.li)	https://pr178.dotns-example-site.dot.li
URL (paseo.li)	https://pr178.dotns-example-site.paseo.li
URL (direct)	https://pr178.dotns-example-site.dot
Duration	66s

View run

Benchmark UI - Passed (342s)

Property	Value
Duration	342s
Domain	pr178-ui.bulletin-benchmarks.dot
CID	bafybeiccerd7pasaurpswqogdpbirszgtua7bjh6ppiil2tudqpkn24pvu
Preview (dot.li)	open
Preview (paseo.li)	open
Preview (direct)	open
Workflow	view

Labels

pkg: cli, type: test, pkg: ui

Test - Passed

231 passed, 0 failed across 231 tests.

View run

$ bun test tests/unit/
bun test v1.2.6 (8ebd5d53)

::group::tests/unit/bulletin/uploadProfiling.test.ts:
(pass) upload profiler > writes schema-complete profile report with peak aggregation [22.00ms]
(pass) upload profiler > default profile path is deterministic for a given fingerprint

::endgroup::

::group::tests/unit/bulletin/uploadManifest.test.ts:
(pass) upload manifest resume behavior > returns stale manifest when fingerprint does not match [3.00ms]
(pass) upload manifest resume behavior > deduplicates completed blocks by index

::endgroup::

::group::tests/unit/bulletin/bulletinCliHelp.test.ts:
(pass) root help lists bulletin command [15.00ms]
(pass) bulletin help shows commands and description [6.00ms]
(pass) bulletin upload help shows all options [5.00ms]
(pass) bulletin upload help shows default values [3.00ms]
(pass) bulletin authorize help shows all options [3.00ms]
(pass) bulletin authorize help shows default values [2.00ms]
(pass) bulletin history help shows options [2.00ms]
(pass) bulletin history:remove help shows usage [2.00ms]
(pass) bulletin history:clear help shows description [2.00ms]
(pass) bulletin help command shows bulletin help [3.00ms]
(pass) bulletin help upload shows upload help [3.00ms]
(pass) bulletin help authorize shows authorize help [3.00ms]
(pass) bulletin status help shows all options [3.00ms]
(pass) bulletin help status shows status help [3.00ms]
(pass) bulletin list alias works [3.00ms]
(pass) bulletin verify help shows usage [3.00ms]
(pass) bulletin help verify shows verify help [3.00ms]

::endgroup::

::group::tests/unit/bulletin/bulletinAuthorizer.test.ts:
(pass) bulletin authorizer default > defaults to //Eve, the seeded AllowedAuthorizers account [1.00ms]
(pass) bulletin authorizer default > is distinct from the sudo key, which stays //Alice
(pass) warnIfDevKeyOnTestnet > warns when the default authorizer is used against previewnet
(pass) warnIfDevKeyOnTestnet > stays silent on paseo-v2 even with the default authorizer
(pass) warnIfDevKeyOnTestnet > stays silent when an explicit signer overrides the default

::endgroup::

::group::tests/unit/content/contentJson.test.ts:
(pass) content view --help shows --json option [2.00ms]
(pass) content set --help shows --json option [1.00ms]
(pass) content set --json emits JSON error when both mnemonic and key-uri provided [3.00ms]

::endgroup::

::group::tests/unit/content/contentHelp.test.ts:
result:  {
  exitCode: 0,
  standardOutput: "Usage: dotns content [options] [command]\n\nManage domain content hashes\n\nOptions:\n  --env <environment>         DotNS environment: paseo-v2 (env: DOTNS_ENV)\n  --network <environment>     Alias for --env\n  --rpc <wsUrl>               WebSocket RPC endpoint (env: DOTNS_RPC)\n  --keystore-path <path>      Keystore path (env: DOTNS_KEYSTORE_PATH)\n  --min-balance <pas>         Minimum balance in PAS (env:\n                              DOTNS_MIN_BALANCE_PAS)\n  --account <name>            Keystore account name (default: keystore default)\n  --password <pw>             Keystore password (env: DOTNS_KEYSTORE_PASSWORD)\n  -m, --mnemonic <phrase>     BIP39 mnemonic phrase (env: DOTNS_MNEMONIC)\n  -k, --key-uri <uri>         Substrate key URI (env: DOTNS_KEY_URI)\n  -h, --help                  display help for command\n\nCommands:\n  view [options] <name>       View domain content hash\n  set [options] <name> <cid>  Set domain content hash (IPFS CID)\n  help [command]              display help for command\n",
  standardError: "",
  combinedOutput: "Usage: dotns content [options] [command]\n\nManage domain content hashes\n\nOptions:\n  --env <environment>         DotNS environment: paseo-v2 (env: DOTNS_ENV)\n  --network <environment>     Alias for --env\n  --rpc <wsUrl>               WebSocket RPC endpoint (env: DOTNS_RPC)\n  --keystore-path <path>      Keystore path (env: DOTNS_KEYSTORE_PATH)\n  --min-balance <pas>         Minimum balance in PAS (env:\n                              DOTNS_MIN_BALANCE_PAS)\n  --account <name>            Keystore account name (default: keystore default)\n  --password <pw>             Keystore password (env: DOTNS_KEYSTORE_PASSWORD)\n  -m, --mnemonic <phrase>     BIP39 mnemonic phrase (env: DOTNS_MNEMONIC)\n  -k, --key-uri <uri>         Substrate key URI (env: DOTNS_KEY_URI)\n  -h, --help                  display help for command\n\nCommands:\n  view [options] <name>       View domain content hash\n  set [options] <name> <cid>  Set domain content hash (IPFS CID)\n  help [command]              display help for command\n",
}
(pass) content --help lists subcommands and auth options [2.00ms]
(pass) content view --help shows name argument and options [5.00ms]
(pass) content set --help shows name and cid arguments [2.00ms]

::endgroup::

::group::tests/unit/utils/contractInteractions.test.ts:
(pass) isRevertFlag matches the EVM revert bit > flags=0n → false [1.00ms]
(pass) isRevertFlag matches the EVM revert bit > flags=1n → true
(pass) isRevertFlag matches the EVM revert bit > flags=2n → false
(pass) isRevertFlag matches the EVM revert bit > flags=3n → true
(pass) buildRevertError > empty data returns the unmapped-origin hint
(pass) buildRevertError > known ABI selector decodes to the named error [7.00ms]
(pass) buildRevertError > unknown selector falls back to raw hex [1.00ms]
(pass) decodeContractRevertError > empty data includes operation context
(pass) decodeContractRevertError > non-empty data decodes against the ABI [1.00ms]

::endgroup::

::group::tests/unit/utils/validation.test.ts:
(pass) isCanonicalLabel > accepts lowercase letters, digits and internal hyphens
(pass) isCanonicalLabel > rejects dots, uppercase, spaces and other characters
(pass) isCanonicalLabel > rejects leading or trailing hyphens, empty and overlong labels
(pass) validateCanonicalLabel > throws for a name containing a dot, naming the role
(pass) validateCanonicalLabel > does not throw for a canonical label [1.00ms]
(pass) countTrailingDigits > returns 0 for a label with no trailing digits
(pass) countTrailingDigits > returns the digit run length for a label with trailing digits
(pass) countTrailingDigits > does not count interior digits
(pass) stripTrailingDigits > returns the label unchanged when there are no trailing digits
(pass) stripTrailingDigits > strips the trailing digit run
(pass) validateDomainLabel digit-suffix rule > accepts labels with no trailing digits
(pass) validateDomainLabel digit-suffix rule > accepts labels with exactly two trailing digits
(pass) validateDomainLabel digit-suffix rule > rejects labels with exactly one trailing digit
(pass) validateDomainLabel digit-suffix rule > rejects labels with three or more trailing digits
(pass) validateDomainLabel digit-suffix rule > rejects labels shorter than three characters
(pass) validateDomainLabel digit-suffix rule > rejects labels with uppercase characters
(pass) validateDomainLabel digit-suffix rule > rejects labels with leading or trailing hyphen
(pass) validateGovernanceLabel stem-length rule > accepts stems of five characters or fewer [1.00ms]
(pass) validateGovernanceLabel stem-length rule > rejects stems longer than five characters
(pass) validateGovernanceLabel stem-length rule > inherits the digit-suffix rule from validateDomainLabel

::endgroup::

::group::tests/unit/auth/authHelp.test.ts:
(pass) root help lists auth command [2.00ms]
(pass) auth help shows options and subcommands [2.00ms]
(pass) auth set help shows all options [2.00ms]
(pass) auth list help shows options [1.00ms]
(pass) auth use help shows options [1.00ms]
(pass) auth remove help shows options [2.00ms]
(pass) auth clear help shows options [1.00ms]
(pass) auth parses keystore-path option [2.00ms]
(pass) auth parses password option [1.00ms]
(pass) auth set parses account option [2.00ms]
(pass) auth set parses mnemonic option [2.00ms]
(pass) auth set parses key-uri option [2.00ms]
(pass) auth help command shows help [2.00ms]
(pass) auth help set shows set command help [2.00ms]
(pass) auth help list shows list command help [1.00ms]
(pass) auth help use shows use command help [2.00ms]
(pass) auth help remove shows remove command help [2.00ms]
(pass) auth help clear shows clear command help [2.00ms]

::endgroup::

::group::tests/unit/auth/resolveAuthSourceReadOnly.test.ts:
(pass) resolveAuthSourceReadOnly honours environment variables > $label [1.00ms]
(pass) resolveAuthSourceReadOnly honours environment variables > $label
(pass) resolveAuthSourceReadOnly honours environment variables > $label
(pass) resolveAuthSourceReadOnly honours environment variables > $label
(pass) resolveAuthSourceReadOnly honours environment variables > $label

::endgroup::

::group::tests/unit/auth/authRevert.test.ts:
(pass) auth set rejects account name with forward slash [3.00ms]
(pass) auth set rejects account name with backslash [2.00ms]
(pass) auth set rejects account name that is just a dot [2.00ms]
(pass) auth set rejects account name that is double dots [1.00ms]
(pass) auth set rejects account name starting with dot [2.00ms]
(pass) auth set rejects account name ending with dot [1.00ms]
(pass) auth set rejects account name with special characters [11.00ms]
(pass) auth set rejects account name that is too long [1.00ms]
(pass) auth use rejects non-existent account [80.00ms]
(pass) auth remove rejects non-existent account [69.00ms]

::endgroup::

::group::tests/unit/auth/auth.test.ts:
(pass) auth set creates keystore and stores multiple accounts [271.01ms]
(pass) auth set accepts account names with special characters [404.01ms]
(pass) auth list reports missing keystore [4.00ms]
(pass) auth list shows all accounts and auth types [291.01ms]
(pass) auth use switches default account [412.01ms]
(pass) auth remove last account clears default [66.00ms]
(pass) auth remove preserves remaining accounts and reassigns default [204.01ms]
(pass) auth clear deletes all accounts [69.00ms]
(pass) resolveAuthSource prefers selected keystore account over ambient env mnemonic [200.01ms]
(pass) resolveAuthSource resolves from env mnemonic when only the default keystore path is given
(pass) resolveAuthSource prefers selected keystore account over ambient env key URI [137.00ms]
(pass) auth set rejects weak password supplied by flag for new keystore [4.00ms]
(pass) auth set rejects weak password supplied by env for new keystore [2.00ms]

::endgroup::

::group::tests/unit/escrow/escrowFormatting.test.ts:
(pass) formatRefundEntryLine > marks entries past their cooldown as claimable [1.00ms]
(pass) formatRefundEntryLine > marks entries inside their cooldown window with remaining seconds
(pass) formatRefundEntryLine > renders the amount as a PAS decimal string
(pass) formatRefundEntryLine > truncates large tokenIds for terminal display
(pass) totalEscrowAmount > is zero for no positions
(pass) totalEscrowAmount > sums position amounts
(pass) isRefundableDeposit > is true only when the position holds an amount
(pass) cooldownRemainingSeconds > returns the seconds left, clamped to zero once elapsed
(pass) formatCooldown > formats seconds and minutes
(pass) formatPositionStatus > held when not released
(pass) formatPositionStatus > embeds the cooldown countdown while released and waiting
(pass) formatPositionStatus > claimable once the cooldown elapses
(pass) formatPositionStatus > claimed after withdrawal
(pass) formatPositionsTable > returns no lines for an empty set [1.00ms]
(pass) formatPositionsTable > renders a header plus one aligned row per position with the cooldown

::endgroup::

::group::tests/unit/escrow/escrowHelp.test.ts:
(pass) root help lists escrow command [2.00ms]
(pass) escrow help shows the subcommand description and subcommands [2.00ms]
(pass) escrow balance help describes the claimable pull-payment balance [1.00ms]
(pass) escrow positions help describes the list and total [1.00ms]
(pass) escrow status help describes the read-only position lookup [2.00ms]
(pass) escrow release help describes the approve-and-release sequence [1.00ms]
(pass) escrow withdraw help describes the post-cooldown step [1.00ms]
(pass) escrow claim-withdrawal help describes the overpayment ledger [2.00ms]
(pass) escrow refunds help lists list/claim/claim-batch [1.00ms]
(pass) escrow refunds list help exposes pagination options [1.00ms]
(pass) escrow refunds claim help requires an entry id positional [2.00ms]
(pass) escrow refunds claim-batch help accepts variadic ids [1.00ms]

::endgroup::

::group::tests/unit/register/registerJson.test.ts:
(pass) register domain --help shows --json option [2.00ms]
(pass) register subname --help shows --json option [1.00ms]
(pass) register domain --json emits JSON error when --transfer without --to [2.00ms]

::endgroup::

::group::tests/unit/register/registerOwnerConflicts.test.ts:
(pass) register domain rejects --owner with --transfer [3.00ms]
(pass) register domain rejects --owner with --reverse [1.00ms]
(pass) register domain rejects --owner with --governance [2.00ms]

::endgroup::

::group::tests/unit/register/registrationManifest.test.ts:
(pass) registration manifest persistence > saves a record and reads it back by label [61.00ms]
(pass) registration manifest persistence > encrypts the secret at rest (never stored in plaintext) [73.00ms]
(pass) registration manifest persistence > decrypts the secret with the correct credential [125.00ms]
(pass) registration manifest persistence > rejects decryption with the wrong credential [132.00ms]
(pass) registration manifest persistence > lists records for the env + caller, newest commit first [122.00ms]
(pass) registration manifest persistence > isolates records by env and caller [132.00ms]
(pass) registration manifest persistence > deletes a record [64.00ms]
(pass) registration manifest persistence > returns empty when nothing is cached [1.00ms]
(pass) registration manifest persistence > clear record selection scopes to a requested label [132.00ms]
(pass) registration manifest persistence > clear record selection errors when a requested label is missing [60.00ms]
(pass) resolveManifestCredential > prefers password, then mnemonic, then key URI
(pass) resolveManifestCredential > returns null when no credential is available
(pass) resolveManifestCredential > uses env mnemonic and key URI for registration cache encryption [1.00ms]

::endgroup::

::group::tests/unit/register/registerHelp.test.ts:
(pass) root help lists register command [3.00ms]
(pass) register help shows subcommands [2.00ms]
(pass) register domain help shows options [2.00ms]
(pass) register subname help shows options [1.00ms]
(pass) register domain parses reverse flag [2.00ms]
(pass) register domain parses governance flag [2.00ms]
(pass) register domain parses owner option [2.00ms]
(pass) register domain parses transfer with destination [2.00ms]
(pass) register domain parses account option [1.00ms]
(pass) register domain parses keystore-path option [2.00ms]
(pass) register domain parses password option [2.00ms]
(pass) register domain parses mnemonic option [1.00ms]
(pass) register domain parses key-uri option [2.00ms]
(pass) register domain parses commitment-buffer option [2.00ms]
(pass) register domain parses commitment-buffer alias --cb [2.00ms]
(pass) register subname parses name and parent [2.00ms]
(pass) register subname parses owner option [2.00ms]
(pass) getCommitmentBufferSeconds defaults to 6 when env is not set
(pass) getCommitmentBufferSeconds reads from DOTNS_COMMITMENT_BUFFER env variable
(pass) COMMITMENT_POLL_INTERVAL_MS is 2000 [1.00ms]
(pass) COMMITMENT_POLL_TIMEOUT_MS is 30000

::endgroup::

::group::tests/unit/pop/popJson.test.ts:
(pass) pop info --help shows --json option [4.00ms]
(pass) pop status --help shows --json option [2.00ms]

::endgroup::

::group::tests/unit/pop/setPopHelp.test.ts:
(pass) root help lists pop command [2.00ms]
(pass) pop help shows commands and description [2.00ms]
(pass) pop help shows auth options [3.00ms]
(pass) pop info help shows description [1.00ms]
(pass) pop status help shows description [1.00ms]
(pass) pop info help shows auth options [2.00ms]
(pass) pop info parses auth options at pop level [1.00ms]
(pass) pop info parses auth options at info level [2.00ms]
(pass) pop help command shows pop help [1.00ms]
(pass) pop help status shows info help [2.00ms]
(pass) pop help info shows info help [1.00ms]

::endgroup::

::group::tests/unit/account/accountHelp.test.ts:
(pass) account --help lists subcommands including is-mapped, is-whitelisted, whitelist [3.00ms]
(pass) account is-mapped --help shows address argument and --json [1.00ms]
(pass) account is-whitelisted --help shows address argument and --json [1.00ms]
(pass) account whitelist --help shows address argument, --remove, and --json [2.00ms]
(pass) account is alias works for is-mapped [1.00ms]
(pass) account iw alias works for is-whitelisted [1.00ms]

::endgroup::

::group::tests/unit/text/textHelp.test.ts:
(pass) text --help lists subcommands and auth options [1.00ms]
(pass) text view --help shows name and key arguments [2.00ms]
(pass) text set --help shows name, key, and value arguments [1.00ms]

::endgroup::

::group::tests/unit/text/textJson.test.ts:
(pass) text view --help shows --json option [2.00ms]
(pass) text set --help shows --json option [2.00ms]
(pass) text set --json emits JSON error when both mnemonic and key-uri provided [2.00ms]

::endgroup::

::group::tests/unit/lookup/lookupHelp.test.ts:
(pass) lookup --help lists subcommands and auth options [2.00ms]
(pass) lookup name --help shows label argument and options [2.00ms]
(pass) lookup owner-of --help shows label argument and options [2.00ms]
(pass) lookup transfer --help shows label argument and destination option [2.00ms]
(pass) lookup transfer parses destination at transfer level [1.00ms]
(pass) lookup transfer parses auth options at lookup level [1.00ms]

::endgroup::

::group::tests/unit/store/storeHelp.test.ts:
(pass) store --help lists subcommands [3.00ms]
(pass) store claim --help shows description and auth options [2.00ms]
(pass) store info --help shows auth options [1.00ms]
(pass) store list --help shows options [3.00ms]
(pass) store get --help shows key argument [2.00ms]
(pass) store set --help shows key and value arguments with auth [2.00ms]
(pass) store delete --help shows key argument with auth [2.00ms]

::endgroup::

::group::tests/unit/delegate/delegateHelp.test.ts:
(pass) delegate --help lists set, revoke, status and auth options [4.00ms]
(pass) delegate set --help shows name and delegate arguments [2.00ms]
(pass) delegate revoke --help shows name argument [2.00ms]
(pass) delegate status --help shows name argument and --json [2.00ms]

::endgroup::

::group::tests/unit/cli/bulletinRpc.test.ts:
(pass) paseo-v2 default resolves to the existing bulletin RPC [1.00ms]
(pass) explicit argument wins over env var and active env
(pass) env var wins over active env config when no explicit argument
(pass) falls back to active env's bulletin RPC
(pass) throws when nothing is configured (synthetic case)
(pass) bulletin cache Asset Hub RPC uses merged CLI rpc before DOTNS_RPC
(pass) bulletin cache Asset Hub RPC uses selected environment when no rpc override exists
(pass) bulletin cache rejects custom Bulletin env override without matching target
(pass) bulletin cache accepts custom Bulletin override with explicit environment
(pass) bulletin cache custom Bulletin with DOTNS_ENV ignores stale DOTNS_RPC
(pass) bulletin cache accepts custom Bulletin override with explicit Asset Hub RPC

::endgroup::

::group::tests/unit/cli/environment.test.ts:
(pass) defaults to paseo-v2
(pass) accepts friendly paseo-v2 aliases
(pass) DOTNS_ENV selects rpc and contract set
(pass) --env takes precedence over DOTNS_ENV while --rpc only overrides endpoint

::endgroup::

 231 pass
 0 fail
 730 expect() calls
Ran 231 tests across 28 files. [3.91s]