Add opt-in skip for the build step in dot deploy#30
Merged
UtkarshBhardwaj007 merged 1 commit intomainfrom Apr 20, 2026
Merged
Conversation
Today `dot deploy` unconditionally runs `runBuild` before uploading, which is the right default but wasteful when the user has already built and just wants to re-upload artifacts. Add a "build before deploy?" prompt as the first interactive step (defaults to yes, Enter to proceed) and a `--no-build` flag for the non-interactive path. The confirm screen and headless summary both show which mode the run is using, and the running view renders the build phase as `complete · skipped` when bypassed — mirroring how the `playground` phase already handles its skip case. `runDeploy` already supported `skipBuild` at the orchestrator level, so no changes were needed there. The CLI just threads the flag through.
Contributor
|
Dev build ready — try this branch: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dot deploy, defaulting to "yes" so the common path stays a single Enter press.--no-buildflag for the non-interactive path (commander-native auto-negation; default is to build).Buildrow (rebuild first/skip (use existing)), and when skipping, the running view renders the build phase ascomplete · skipped— mirroring how theplaygroundphase already handles its skip case.runDeployalready supportedskipBuild, so the CLI just threads the flag through.Test plan
bun run test— all 190 tests pass (6 summary tests including a new one for theBuildrow)tsc --noEmitcleandot deploy→ hit Enter on the build prompt → verify build runs (current default behaviour preserved)dot deploy→ select "no" on the build prompt → verify the build phase shows asskippedand the upload still succeedsdot deploy --signer dev --domain foo --buildDir dist --playground --no-build→ verify headless path skips the build and showsskip (use existing)in the summarydot deploy --no-buildwith no other flags → verify interactive mode pre-fills skip and does NOT show the build prompt, but still asks for signer/domain/etc.