try-runtime job for PreviewNet#140
Open
rosarp wants to merge 9 commits into
Open
Conversation
ilchu
approved these changes
Jun 9, 2026
ilchu
left a comment
ilchu
left a comment
Collaborator
There was a problem hiding this comment.
Nothing blocking, but I did find a few followups. Feel free to add them in this PR or I'd appreciate if you could create issues.
The biggest one that wasn't your code related: across the 3 main pallets (storage provider, s3 registry and drive registry) the latter doesn't have the try-runtime feature at all. We'd definitely need that for completeness of this CI check, but whether you want to do it separately or on top of this is up to you.
bkontur
reviewed
Jun 11, 2026
bkontur
reviewed
Jun 11, 2026
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
bkontur
requested changes
Jun 11, 2026
.github/env is now the single source of truth for tool versions: the justfile loads it via dotenv (shell-exported vars still override file values) instead of duplicating version strings. The try-runtime download is verified against pinned SHA256s, mirroring the bulletin-chain setup. The migration-check workflow no longer needs to pass the version into just, which also removes a template-injection surface in its run blocks.
pallet-drive-registry was the only one of the three main pallets without a try-runtime feature, so the new migration-check CI job built the runtimes with the pallet's try-runtime hooks disabled. Add the feature and propagate it through the precompile and both runtimes.
Set persist-credentials: false on all three checkouts (artipacked) and accept the runtime-resolved CI_IMAGE container ref in .github/zizmor.yml (unpinned-images), matching the existing exceptions for the other set-image consumers. The template-injection findings were already resolved by sourcing the try-runtime version from .github/env.
ilchu
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #103