test(pallet): add tests for challenges, checkpoints, replicas, events, and runtime API#146
Merged
Merged
Conversation
…, and runtime API Add comprehensive test coverage for the storage-provider pallet: - Challenge tests: cost-split boundary conditions, offchain challenge flows - Checkpoint tests: scheduling, fallback, leader election, missed checkpoint handling - Miscellaneous: event emission, remove_slashed, multiaddr validation - Replica tests: full replica sync lifecycle - Runtime API tests: provider/bucket/agreement query coverage - Add `run_to_block` warning comment in mock.rs
This was referenced Jun 8, 2026
ilchu
reviewed
Jun 9, 2026
Address review feedback on PR #146: - Include StorageProvider::on_finalize in run_to_block (guarded by block > 1 to skip genesis), matching real runtime behavior - Remove respond_to_challenge_fails_expired test (unreachable scenario since on_finalize now auto-slashes expired challenges) - Replace manual on_finalize(101) calls in 3 slash tests with run_to_block(102) - Remove redundant #[allow(dead_code)] on mock helpers
…ech/web3-storage into test/pallet-coverage-improvement
ilchu
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#144
Split from #139 (PR 2 of 4). Independent of the other PRs — pallet-only changes.
Add comprehensive test coverage for the storage-provider pallet:
remove_slashed, multiaddr validationPR stack
devdevTest plan
cargo test -p pallet-storage-providerpasses