Skip to content

fix: revert provider deregistration#163

Open
danielbui12 wants to merge 7 commits into
devfrom
tung/provider_deregistration_fix
Open

fix: revert provider deregistration#163
danielbui12 wants to merge 7 commits into
devfrom
tung/provider_deregistration_fix

Conversation

@danielbui12

Copy link
Copy Markdown
Member

Changes

  • committed_bytes == 0 is the authoritative gate, proven faithful by auditing every StorageAgreements insert/remove site; each is balanced against a counter increment/decrement. No provider→bucket reverse index needed.
  • remove cancel_deregistration, complete_deregistration

Issue

- committed_bytes == 0 is the authoritative gate, proven faithful by auditing every
  StorageAgreements insert/remove site; each is balanced against a counter increment/decrement.
  No provider→bucket reverse index needed.
- remove cancel_deregistration, complete_deregistration
@danielbui12

Copy link
Copy Markdown
Member Author

/cmd bench --runtime web3-storage-paseo --runtime storage-parachain-runtime

@danielbui12

Copy link
Copy Markdown
Member Author

/cmd fmt

@danielbui12

Copy link
Copy Markdown
Member Author

/cmd fmt

@danielbui12

Copy link
Copy Markdown
Member Author

/cmd fmt

@danielbui12

Copy link
Copy Markdown
Member Author

/cmd bench --runtime web3-storage-paseo --runtime storage-parachain-runtime

@github-actions

Copy link
Copy Markdown
Contributor

Command "bench --runtime web3-storage-paseo --runtime storage-parachain-runtime" has started 🚀 See logs here

…-storage-paseo --runtime storage-parachain-runtime'
@github-actions

Copy link
Copy Markdown
Contributor

Command "bench --runtime web3-storage-paseo --runtime storage-parachain-runtime" has finished ✅ See logs here

Details

Subweight results:
File Extrinsic Old New Change [%]
pallet/src/weights.rs deregister_provider 132.00us 129.08ms +97688.64
runtime/src/weights/pallet_storage_provider.rs deregister_provider 139.45us 132.40ms +94844.12
runtimes/web3-storage-paseo/src/weights/pallet_storage_provider.rs deregister_provider 139.52us 132.32ms +94744.17
runtime/src/weights/pallet_revive.rs seal_return 26.38us 39.19us +48.56
runtime/src/weights/pallet_revive.rs seal_copy_to_contract 212.33us 310.87us +46.41
runtime/src/weights/pallet_revive.rs identity 118.35us 157.14us +32.78
runtime/src/weights/pallet_revive.rs seal_call_data_copy 119.81us 156.32us +30.47
runtime/src/weights/pallet_revive.rs seal_gas_limit 275.00ns 328.00ns +19.27
runtime/src/weights/pallet_revive.rs seal_value_transferred 297.00ns 337.00ns +13.47
runtime/src/weights/pallet_revive.rs instr 1.35ms 1.52ms +12.27
runtime/src/weights/xcm/pallet_xcm_benchmarks_generic.rs descend_origin 933.00ns 1.04us +11.15
runtime/src/weights/xcm/pallet_xcm_benchmarks_generic.rs alias_origin 943.00ns 1.04us +10.82
runtime/src/weights/xcm/pallet_xcm_benchmarks_generic.rs unpaid_execution 908.00ns 1.01us +10.79
runtime/src/weights/pallet_revive.rs seal_caller 345.00ns 382.00ns +10.72
runtime/src/weights/xcm/pallet_xcm_benchmarks_generic.rs asset_claimer 940.00ns 1.04us +10.64
runtime/src/weights/xcm/pallet_xcm_benchmarks_generic.rs expect_asset 1.02us 1.13us +10.38
runtime/src/weights/xcm/pallet_xcm_benchmarks_generic.rs set_fees_mode 895.00ns 981.00ns +9.61
runtime/src/weights/xcm/pallet_xcm_benchmarks_generic.rs clear_error 903.00ns 987.00ns +9.30
runtime/src/weights/xcm/pallet_xcm_benchmarks_generic.rs clear_topic 894.00ns 976.00ns +9.17
runtime/src/weights/xcm/pallet_xcm_benchmarks_generic.rs set_topic 900.00ns 981.00ns +9.00
runtime/src/weights/pallet_revive.rs caller_is_root 1.17us 1.28us +8.77
runtime/src/weights/pallet_revive.rs seal_call_precompile 218.14us 236.33us +8.34
runtime/src/weights/xcm/pallet_xcm_benchmarks_generic.rs clear_transact_status 973.00ns 1.05us +8.32
runtime/src/weights/xcm/pallet_xcm_benchmarks_generic.rs clear_origin 927.00ns 1.00us +8.20
runtime/src/weights/xcm/pallet_xcm_benchmarks_generic.rs set_appendix 923.00ns 998.00ns +8.13
runtime/src/weights/pallet_revive.rs caller_is_origin 1.21us 1.31us +7.84
runtime/src/weights/pallet_revive.rs seal_deposit_event 91.86us 98.68us +7.43
runtime/src/weights/pallet_revive.rs seal_call_data_load 284.00ns 303.00ns +6.69
runtime/src/weights/cumulus_pallet_parachain_system.rs block_weight_tx_extension_full_core 4.70us 4.98us +5.85
runtime/src/weights/pallet_revive.rs minimum_balance 1.44us 1.53us +5.75
runtime/src/weights/pallet_revive.rs seal_address 319.00ns 337.00ns +5.64
runtime/src/weights/xcm/pallet_xcm_benchmarks_generic.rs set_error_handler 937.00ns 988.00ns +5.44
runtime/src/weights/pallet_revive.rs rollback_transient_storage 1.36us 1.27us -6.25
Command output:

args: Namespace(command='bench', continue_on_fail=False, quiet=False, clean=False, runtime=['storage-parachain-runtime'], pallet=[], steps=50, repeat=20, profile='production')
Created temp dir: /tmp/tmpu0mx3sk9
Provided runtimes: ['storage-parachain-runtime']
Cargo profile: production
Filtered out runtimes: {'storage-parachain-runtime': {'name': 'storage-parachain-runtime', 'package': 'storage-parachain-runtime', 'path': 'runtime', 'build_command': 'build-runtime', 'zombienet_config': 'zombienet.toml', 'chain_spec_script': 'scripts/build-chain-spec.sh', 'uris': ['TODO: update WSS'], 'integration_tests': True, 'try_runtime': {'spec_name_check': '--disable-spec-name-check', 'extra_flags': '--blocktime 24000 --disable-spec-version-check'}, 'benchmarks_templates': {'pallet_xcm_benchmarks::generic': 'templates/xcm-bench-template.hbs', 'pallet_xcm_benchmarks::fungible': 'templates/xcm-bench-template.hbs'}}}
-- compiling the runtime storage-parachain-runtime
-- listing pallets for benchmark for storage-parachain-runtime
frame-omni-bencher v1 benchmark pallet --no-csv-header --all --list --runtime=target/production/wbuild/storage-parachain-runtime/storage_parachain_runtime.wasm
Pallets in {'name': 'storage-parachain-runtime', 'package': 'storage-parachain-runtime', 'path': 'runtime', 'build_command': 'build-runtime', 'zombienet_config': 'zombienet.toml', 'chain_spec_script': 'scripts/build-chain-spec.sh', 'uris': ['TODO: update WSS'], 'integration_tests': True, 'try_runtime': {'spec_name_check': '--disable-spec-name-check', 'extra_flags': '--blocktime 24000 --disable-spec-version-check'}, 'benchmarks_templates': {'pallet_xcm_benchmarks::generic': 'templates/xcm-bench-template.hbs', 'pallet_xcm_benchmarks::fungible': 'templates/xcm-bench-template.hbs'}}: ['pallet_xcm_benchmarks::generic', 'pallet_message_queue', 'pallet_xcm_benchmarks::fungible', 'pallet_sudo', 'pallet_s3_registry', 'pallet_timestamp', 'cumulus_pallet_parachain_system', 'pallet_session', 'pallet_xcm', 'pallet_balances', 'frame_system_extensions', 'pallet_collator_selection', 'pallet_revive', 'cumulus_pallet_xcmp_queue', 'pallet_storage_provider', 'pallet_drive_registry', 'cumulus_pallet_weight_reclaim', 'pallet_transaction_payment', 'frame_system']
Filtered out runtimes & pallets: {'storage-parachain-runtime': ['pallet_xcm_benchmarks::generic', 'pallet_message_queue', 'pallet_xcm_benchmarks::fungible', 'pallet_sudo', 'pallet_s3_registry', 'pallet_timestamp', 'cumulus_pallet_parachain_system', 'pallet_session', 'pallet_xcm', 'pallet_balances', 'frame_system_extensions', 'pallet_collator_selection', 'pallet_revive', 'cumulus_pallet_xcmp_queue', 'pallet_storage_provider', 'pallet_drive_registry', 'cumulus_pallet_weight_reclaim', 'pallet_transaction_payment', 'frame_system']}
-- config: {'name': 'storage-parachain-runtime', 'package': 'storage-parachain-runtime', 'path': 'runtime', 'build_command': 'build-runtime', 'zombienet_config': 'zombienet.toml', 'chain_spec_script': 'scripts/build-chain-spec.sh', 'uris': ['TODO: update WSS'], 'integration_tests': True, 'try_runtime': {'spec_name_check': '--disable-spec-name-check', 'extra_flags': '--blocktime 24000 --disable-spec-version-check'}, 'benchmarks_templates': {'pallet_xcm_benchmarks::generic': 'templates/xcm-bench-template.hbs', 'pallet_xcm_benchmarks::fungible': 'templates/xcm-bench-template.hbs'}}
-- benchmarking pallet_xcm_benchmarks::generic in storage-parachain-runtime into ./runtime/src/weights/xcm using template templates/xcm-bench-template.hbs
-- config: {'name': 'storage-parachain-runtime', 'package': 'storage-parachain-runtime', 'path': 'runtime', 'build_command': 'build-runtime', 'zombienet_config': 'zombienet.toml', 'chain_spec_script': 'scripts/build-chain-spec.sh', 'uris': ['TODO: update WSS'], 'integration_tests': True, 'try_runtime': {'spec_name_check': '--disable-spec-name-check', 'extra_flags': '--blocktime 24000 --disable-spec-version-check'}, 'benchmarks_templates': {'pallet_xcm_benchmarks::generic': 'templates/xcm-bench-template.hbs', 'pallet_xcm_benchmarks::fungible': 'templates/xcm-bench-template.hbs'}}
-- benchmarking pallet_message_queue in storage-parachain-runtime into ./runtime/src/weights using template None
-- config: {'name': 'storage-parachain-runtime', 'package': 'storage-parachain-runtime', 'path': 'runtime', 'build_command': 'build-runtime', 'zombienet_config': 'zombienet.toml', 'chain_spec_script': 'scripts/build-chain-spec.sh', 'uris': ['TODO: update WSS'], 'integration_tests': True, 'try_runtime': {'spec_name_check': '--disable-spec-name-check', 'extra_flags': '--blocktime 24000 --disable-spec-version-check'}, 'benchmarks_templates': {'pallet_xcm_benchmarks::generic': 'templates/xcm-bench-template.hbs', 'pallet_xcm_benchmarks::fungible': 'templates/xcm-bench-template.hbs'}}
-- benchmarking pallet_xcm_benchmarks::fungible in storage-parachain-runtime into ./runtime/src/weights/xcm using template templates/xcm-bench-template.hbs
-- config: {'name': 'storage-parachain-runtime', 'package': 'storage-parachain-runtime', 'path': 'runtime', 'build_command': 'build-runtime', 'zombienet_config': 'zombienet.toml', 'chain_spec_script': 'scripts/build-chain-spec.sh', 'uris': ['TODO: update WSS'], 'integration_tests': True, 'try_runtime': {'spec_name_check': '--disable-spec-name-check', 'extra_flags': '--blocktime 24000 --disable-spec-version-check'}, 'benchmarks_templates': {'pallet_xcm_benchmarks::generic': 'templates/xcm-bench-template.hbs', 'pallet_xcm_benchmarks::fungible': 'templates/xcm-bench-template.hbs'}}
-- benchmarking pallet_sudo in storage-parachain-runtime into ./runtime/src/weights using template None
-- config: {'name': 'storage-parachain-runtime', 'package': 'storage-parachain-runtime', 'path': 'runtime', 'build_command': 'build-runtime', 'zombienet_config': 'zombienet.toml', 'chain_spec_script': 'scripts/build-chain-spec.sh', 'uris': ['TODO: update WSS'], 'integration_tests': True, 'try_runtime': {'spec_name_check': '--disable-spec-name-check', 'extra_flags': '--blocktime 24000 --disable-spec-version-check'}, 'benchmarks_templates': {'pallet_xcm_benchmarks::generic': 'templates/xcm-bench-template.hbs', 'pallet_xcm_benchmarks::fungible': 'templates/xcm-bench-template.hbs'}}
-- benchmarking pallet_s3_registry in storage-parachain-runtime into ./runtime/src/weights using template None
-- config: {'name': 'storage-parachain-runtime', 'package': 'storage-parachain-runtime', 'path': 'runtime', 'build_command': 'build-runtime', 'zombienet_config': 'zombienet.toml', 'chain_spec_script': 'scripts/build-chain-spec.sh', 'uris': ['TODO: update WSS'], 'integration_tests': True, 'try_runtime': {'spec_name_check': '--disable-spec-name-check', 'extra_flags': '--blocktime 24000 --disable-spec-version-check'}, 'benchmarks_templates': {'pallet_xcm_benchmarks::generic': 'templates/xcm-bench-template.hbs', 'pallet_xcm_benchmarks::fungible': 'templates/xcm-bench-template.hbs'}}
-- benchmarking pallet_timestamp in storage-parachain-runtime into ./runtime/src/weights using template None
-- config: {'name': 'storage-parachain-runtime', 'package': 'storage-parachain-runtime', 'path': 'runtime', 'build_command': 'build-runtime', 'zombienet_config': 'zombienet.toml', 'chain_spec_script': 'scripts/build-chain-spec.sh', 'uris': ['TODO: update WSS'], 'integration_tests': True, 'try_runtime': {'spec_name_check': '--disable-spec-name-check', 'extra_flags': '--blocktime 24000 --disable-spec-version-check'}, 'benchmarks_templates': {'pallet_xcm_benchmarks::generic': 'templates/xcm-bench-template.hbs', 'pallet_xcm_benchmarks::fungible': 'templates/xcm-bench-template.hbs'}}
-- benchmarking cumulus_pallet_parachain_system in storage-parachain-runtime into ./runtime/src/weights using template None
-- config: {'name': 'storage-parachain-runtime', 'package': 'storage-parachain-runtime', 'path': 'runtime', 'build_command': 'build-runtime', 'zombienet_config': 'zombienet.toml', 'chain_spec_script': 'scripts/build-chain-spec.sh', 'uris': ['TODO: update WSS'], 'integration_tests': True, 'try_runtime': {'spec_name_check': '--disable-spec-name-check', 'extra_flags': '--blocktime 24000 --disable-spec-version-check'}, 'benchmarks_templates': {'pallet_xcm_benchmarks::generic': 'templates/xcm-bench-template.hbs', 'pallet_xcm_benchmarks::fungible': 'templates/xcm-bench-template.hbs'}}
-- benchmarking pallet_session in storage-parachain-runtime into ./runtime/src/weights using template None
-- config: {'name': 'storage-parachain-runtime', 'package': 'storage-parachain-runtime', 'path': 'runtime', 'build_command': 'build-runtime', 'zombienet_config': 'zombienet.toml', 'chain_spec_script': 'scripts/build-chain-spec.sh', 'uris': ['TODO: update WSS'], 'integration_tests': True, 'try_runtime': {'spec_name_check': '--disable-spec-name-check', 'extra_flags': '--blocktime 24000 --disable-spec-version-check'}, 'benchmarks_templates': {'pallet_xcm_benchmarks::generic': 'templates/xcm-bench-template.hbs', 'pallet_xcm_benchmarks::fungible': 'templates/xcm-bench-template.hbs'}}
-- benchmarking pallet_xcm in storage-parachain-runtime into ./runtime/src/weights using template None
-- config: {'name': 'storage-parachain-runtime', 'package': 'storage-parachain-runtime', 'path': 'runtime', 'build_command': 'build-runtime', 'zombienet_config': 'zombienet.toml', 'chain_spec_script': 'scripts/build-chain-spec.sh', 'uris': ['TODO: update WSS'], 'integration_tests': True, 'try_runtime': {'spec_name_check': '--disable-spec-name-check', 'extra_flags': '--blocktime 24000 --disable-spec-version-check'}, 'benchmarks_templates': {'pallet_xcm_benchmarks::generic': 'templates/xcm-bench-template.hbs', 'pallet_xcm_benchmarks::fungible': 'templates/xcm-bench-template.hbs'}}
-- benchmarking pallet_balances in storage-parachain-runtime into ./runtime/src/weights using template None
-- config: {'name': 'storage-parachain-runtime', 'package': 'storage-parachain-runtime', 'path': 'runtime', 'build_command': 'build-runtime', 'zombienet_config': 'zombienet.toml', 'chain_spec_script': 'scripts/build-chain-spec.sh', 'uris': ['TODO: update WSS'], 'integration_tests': True, 'try_runtime': {'spec_name_check': '--disable-spec-name-check', 'extra_flags': '--blocktime 24000 --disable-spec-version-check'}, 'benchmarks_templates': {'pallet_xcm_benchmarks::generic': 'templates/xcm-bench-template.hbs', 'pallet_xcm_benchmarks::fungible': 'templates/xcm-bench-template.hbs'}}
-- benchmarking frame_system_extensions in storage-parachain-runtime into ./runtime/src/weights using template None
-- config: {'name': 'storage-parachain-runtime', 'package': 'storage-parachain-runtime', 'path': 'runtime', 'build_command': 'build-runtime', 'zombienet_config': 'zombienet.toml', 'chain_spec_script': 'scripts/build-chain-spec.sh', 'uris': ['TODO: update WSS'], 'integration_tests': True, 'try_runtime': {'spec_name_check': '--disable-spec-name-check', 'extra_flags': '--blocktime 24000 --disable-spec-version-check'}, 'benchmarks_templates': {'pallet_xcm_benchmarks::generic': 'templates/xcm-bench-template.hbs', 'pallet_xcm_benchmarks::fungible': 'templates/xcm-bench-template.hbs'}}
-- benchmarking pallet_collator_selection in storage-parachain-runtime into ./runtime/src/weights using template None
-- config: {'name': 'storage-parachain-runtime', 'package': 'storage-parachain-runtime', 'path': 'runtime', 'build_command': 'build-runtime', 'zombienet_config': 'zombienet.toml', 'chain_spec_script': 'scripts/build-chain-spec.sh', 'uris': ['TODO: update WSS'], 'integration_tests': True, 'try_runtime': {'spec_name_check': '--disable-spec-name-check', 'extra_flags': '--blocktime 24000 --disable-spec-version-check'}, 'benchmarks_templates': {'pallet_xcm_benchmarks::generic': 'templates/xcm-bench-template.hbs', 'pallet_xcm_benchmarks::fungible': 'templates/xcm-bench-template.hbs'}}
-- benchmarking pallet_revive in storage-parachain-runtime into ./runtime/src/weights using template None
-- config: {'name': 'storage-parachain-runtime', 'package': 'storage-parachain-runtime', 'path': 'runtime', 'build_command': 'build-runtime', 'zombienet_config': 'zombienet.toml', 'chain_spec_script': 'scripts/build-chain-spec.sh', 'uris': ['TODO: update WSS'], 'integration_tests': True, 'try_runtime': {'spec_name_check': '--disable-spec-name-check', 'extra_flags': '--blocktime 24000 --disable-spec-version-check'}, 'benchmarks_templates': {'pallet_xcm_benchmarks::generic': 'templates/xcm-bench-template.hbs', 'pallet_xcm_benchmarks::fungible': 'templates/xcm-bench-template.hbs'}}
-- benchmarking cumulus_pallet_xcmp_queue in storage-parachain-runtime into ./runtime/src/weights using template None
-- config: {'name': 'storage-parachain-runtime', 'package': 'storage-parachain-runtime', 'path': 'runtime', 'build_command': 'build-runtime', 'zombienet_config': 'zombienet.toml', 'chain_spec_script': 'scripts/build-chain-spec.sh', 'uris': ['TODO: update WSS'], 'integration_tests': True, 'try_runtime': {'spec_name_check': '--disable-spec-name-check', 'extra_flags': '--blocktime 24000 --disable-spec-version-check'}, 'benchmarks_templates': {'pallet_xcm_benchmarks::generic': 'templates/xcm-bench-template.hbs', 'pallet_xcm_benchmarks::fungible': 'templates/xcm-bench-template.hbs'}}
-- benchmarking pallet_storage_provider in storage-parachain-runtime into ./runtime/src/weights using template None
-- config: {'name': 'storage-parachain-runtime', 'package': 'storage-parachain-runtime', 'path': 'runtime', 'build_command': 'build-runtime', 'zombienet_config': 'zombienet.toml', 'chain_spec_script': 'scripts/build-chain-spec.sh', 'uris': ['TODO: update WSS'], 'integration_tests': True, 'try_runtime': {'spec_name_check': '--disable-spec-name-check', 'extra_flags': '--blocktime 24000 --disable-spec-version-check'}, 'benchmarks_templates': {'pallet_xcm_benchmarks::generic': 'templates/xcm-bench-template.hbs', 'pallet_xcm_benchmarks::fungible': 'templates/xcm-bench-template.hbs'}}
-- benchmarking pallet_drive_registry in storage-parachain-runtime into ./runtime/src/weights using template None
-- config: {'name': 'storage-parachain-runtime', 'package': 'storage-parachain-runtime', 'path': 'runtime', 'build_command': 'build-runtime', 'zombienet_config': 'zombienet.toml', 'chain_spec_script': 'scripts/build-chain-spec.sh', 'uris': ['TODO: update WSS'], 'integration_tests': True, 'try_runtime': {'spec_name_check': '--disable-spec-name-check', 'extra_flags': '--blocktime 24000 --disable-spec-version-check'}, 'benchmarks_templates': {'pallet_xcm_benchmarks::generic': 'templates/xcm-bench-template.hbs', 'pallet_xcm_benchmarks::fungible': 'templates/xcm-bench-template.hbs'}}
-- benchmarking cumulus_pallet_weight_reclaim in storage-parachain-runtime into ./runtime/src/weights using template None
-- config: {'name': 'storage-parachain-runtime', 'package': 'storage-parachain-runtime', 'path': 'runtime', 'build_command': 'build-runtime', 'zombienet_config': 'zombienet.toml', 'chain_spec_script': 'scripts/build-chain-spec.sh', 'uris': ['TODO: update WSS'], 'integration_tests': True, 'try_runtime': {'spec_name_check': '--disable-spec-name-check', 'extra_flags': '--blocktime 24000 --disable-spec-version-check'}, 'benchmarks_templates': {'pallet_xcm_benchmarks::generic': 'templates/xcm-bench-template.hbs', 'pallet_xcm_benchmarks::fungible': 'templates/xcm-bench-template.hbs'}}
-- benchmarking pallet_transaction_payment in storage-parachain-runtime into ./runtime/src/weights using template None
-- config: {'name': 'storage-parachain-runtime', 'package': 'storage-parachain-runtime', 'path': 'runtime', 'build_command': 'build-runtime', 'zombienet_config': 'zombienet.toml', 'chain_spec_script': 'scripts/build-chain-spec.sh', 'uris': ['TODO: update WSS'], 'integration_tests': True, 'try_runtime': {'spec_name_check': '--disable-spec-name-check', 'extra_flags': '--blocktime 24000 --disable-spec-version-check'}, 'benchmarks_templates': {'pallet_xcm_benchmarks::generic': 'templates/xcm-bench-template.hbs', 'pallet_xcm_benchmarks::fungible': 'templates/xcm-bench-template.hbs'}}
-- benchmarking frame_system in storage-parachain-runtime into ./runtime/src/weights using template None
✅ Successful benchmarks of runtimes/pallets:
-- storage-parachain-runtime: ['pallet_xcm_benchmarks::generic', 'pallet_message_queue', 'pallet_xcm_benchmarks::fungible', 'pallet_sudo', 'pallet_s3_registry', 'pallet_timestamp', 'cumulus_pallet_parachain_system', 'pallet_session', 'pallet_xcm', 'pallet_balances', 'frame_system_extensions', 'pallet_collator_selection', 'pallet_revive', 'cumulus_pallet_xcmp_queue', 'pallet_storage_provider', 'pallet_drive_registry', 'cumulus_pallet_weight_reclaim', 'pallet_transaction_payment', 'frame_system']
🚀 Done

 Replace the two-phase announce/cancel/complete flow (removed from the
  runtime) with tests for the new single-step deregister_provider:
  - 8.1: succeeds with no active agreements, asserts ProviderDeregistered
    event and that the Providers record is fully removed
  - 8.2: re-registration works after deregister (slot fully freed)
  - 8.3: fails with ProviderHasActiveAgreements when committed_bytes > 0
  - 8.4: fails with ProviderNotFound for a non-provider account

  Drops old 8.2/8.5/8.6 (cancel/complete paths no longer in runtime) and
  old 8.8 (ProviderNotAcceptingPrimary — unrelated to deregistration).
The two-phase deregistration extrinsics (complete_deregister,
cancel_deregister) were removed from the runtime in favor of a single
one-shot deregister_provider, leaving these wrappers calling
nonexistent extrinsics. deregisterProvider is kept.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate optimal provider deregistration

2 participants