Make is_pr_author optional in /cmd#167
Merged
Merged
Conversation
The /cmd flow dispatches cmd-run.yml with `gh workflow run --ref cmd-bot`,
so workflow_dispatch inputs are validated against this branch. After the
PR-author authorization path was dropped from cmd.yml, it stopped sending
is_pr_author, which 422'd the dispatch ("Required input 'is_pr_author' not
provided") because the input was required here.
Make it optional with a default and drop the now-dead IS_PR_AUTHOR env var
(the Run cmd step never read it). Keeping the input declared rather than
removing it avoids an "Unexpected inputs provided" 422 from cmd.yml copies
that still pass the flag, so the two branches can be updated in any order.
Collaborator
Author
|
@danielbui12 take a look |
danielbui12
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The /cmd flow dispatches cmd-run.yml with
gh workflow run --ref cmd-bot, so workflow_dispatch inputs are validated against this branch. After the PR-author authorization path was dropped from cmd.yml (in #158), it stopped sending is_pr_author, which 422'd the dispatch ("Required input 'is_pr_author' not provided") because the input was required here.Make it optional with a default and drop the now-dead IS_PR_AUTHOR env var (the Run cmd step never read it). Keeping the input declared rather than removing it avoids an "Unexpected inputs provided" 422 from cmd.yml copies that still pass the flag, so the two branches can be updated in any order.