test: cover dispatch route boundaries#41
Draft
cursor[bot] wants to merge 3 commits into
Draft
Conversation
Co-authored-by: Parvez Kose <koseparvez@gmail.com>
Co-authored-by: Parvez Kose <koseparvez@gmail.com>
Co-authored-by: Parvez Kose <koseparvez@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NextResponsestub, without changing production behavior.Risky behavior now covered
POST /api/dispatchis the boundary between authentication, untrusted JSON input, live vendor dispatch, and session persistence. The tests guard against unauthorized execution, invalid requests reaching vendors, dropped request options, successful sessions not being associated with the authenticated user, and failures being reported as success.Test files added/updated
test/dispatch-route.test.tstest/support/next-server.tsvitest.config.tsWhy this materially reduces regression risk
A route regression can launch paid external work or lose tracking data. These tests verify the ordering and handoff between auth, validation, adapter execution, and persistence. A mutation removing persistence fails the happy-path test, demonstrating that the suite detects the highest-impact wiring regression.
Validation
npx vitest run test/dispatch-route.test.tswithweb/node_moduleshidden: 8/8 passednpm test: 43/43 passednpm run build: passed