Skip to content

[ENG-4046] Pin the guide tests to a local project so Publish passes on main #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mariojgt merged 1 commit into from
Sep 28, 2026
Merged

[ENG-4046] Pin the guide tests to a local project so Publish passes on main #311

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions tests/guide.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ describe('guide', () => {
delete process.env.PATCHSTACK_SITE_UUID;
delete process.env.PATCHSTACK_ENDPOINT;
delete process.env.PATCHSTACK_TIMEOUT_MS;
delete process.env.PATCHSTACK_ENVIRONMENT;
// A developer's machine. Without this, a CI runner's own variables decide the environment: a
// pull-request build reads as sandbox and the publish job on main as production.
process.env.PATCHSTACK_ENVIRONMENT = 'local';
});

afterEach(async () => {
Expand Down Expand Up @@ -229,8 +231,6 @@ describe('guide', () => {
};

it('prints the four progress steps in order, with the agreed wording', async () => {
// A developer's machine. Without this, a CI runner's own variables name the environment.
process.env.PATCHSTACK_ENVIRONMENT = 'local';
writeJson('package.json', { name: 'fresh-app' });

const output = renderGuideChecklist(await collectGuideState(cwd), false);
Expand Down Expand Up @@ -336,8 +336,6 @@ describe('guide', () => {
});

it('makes connecting the next step on a wired project, with the claim link', async () => {
// A developer's machine. Without this, a CI runner's own variables name the environment.
process.env.PATCHSTACK_ENVIRONMENT = 'local';
wiredProject();

const output = renderGuideChecklist(await collectGuideState(cwd), false);
Expand Down Expand Up @@ -645,7 +643,7 @@ describe('guide on a project with no request path', () => {
beforeEach(async () => {
cwd = await mkdtemp(path.join(tmpdir(), 'patchstack-guide-static-'));
delete process.env.PATCHSTACK_SITE_UUID;
delete process.env.PATCHSTACK_ENVIRONMENT;
process.env.PATCHSTACK_ENVIRONMENT = 'local';
});

afterEach(async () => {
Expand Down
Loading