Sync master with upstream (2026-09-16) - #8
Merged
Merged
Conversation
This advances the C++ version from C++17 to C++23, most of the immediate fallout is from UTF-8 strings in filesystem code. This change keeps the impact minimal by casting at the boundaries rather than changing internal string representations to u8string and char8_t, something that might be desirable down the line.
feat: bump language version to C++23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges upstream/master:
8694a07Merge PR feat: bump language version to C++23 PathOfBuildingCommunity/PathOfBuilding-SimpleGraphic#120 from zao/feat/cpp23-first54950cffeat: bump language version to C++23Clean merge (ort auto-merged
CMakeLists.txt,engine/render/r_main.cpp,engine/system/win/sys_main.cpp,engine/system/win/sys_video.cpp).macOS port: no forward-porting needed.
verify-port.shreports 18 fork-patched files before and after the merge, no dropped or unsignatured fork lines, no file-mode changes, no re-versioned vendored port dirs (P5 clean).Gate for the C++23 bump on macOS is a local arm64 rebuild + runtime smoke test, run after merge.