Verify application route/controller works with {{outlet}} - #140
Merged
Merged
Conversation
…k with {{outlet}}
A reported bug claimed adding a standard application route/controller pair
left {{outlet}} permanently empty, forcing a template-only root component
workaround. This could not be reproduced: with explicit ApplicationRoute and
ApplicationController classes in place, a route transition still renders
correctly into {{outlet}}, verified via app.visit() + DOM inspection.
Documents the finding in the README and adds the route/controller files plus
a regression test to the demo app so this stays covered going forward.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…ADME claim The application-route-outlet test's final assertion passed identically whether or not the application route/controller existed, so it couldn't catch a regression - only the toBeInstanceOf checks were load-bearing. Give the fixture a real failure mode by exercising an async model() hook (the most plausible way a custom Route interacts badly with ember-tui's render bootstrap) and asserting its resolved value reaches the controller. Also narrow the README's "works exactly like it would in a browser Ember app" claim, which overstated what the trivial-class test actually verified. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app/routes/application.ts+app/controllers/application.tspair does not break{{outlet}}(a reported bug claimed it did, but this could not be reproduced).model()hook on the application route and asserting its resolved value reaches the controller, rather than relying only ontoBeInstanceOfchecks.Test plan
pnpm testinember-tui-demo(tests/application-route-outlet-test.gts) passes on top of currentmaineslinton the touched files passes clean🤖 Generated with Claude Code