Skip to content

Fix homepage prose-link spacing and clarify external key custody - #22

Merged
patschmittdev merged 1 commit into
mainfrom
patschmittdev-brochure-link-spacing
Sep 12, 2026
Merged

patschmittdev merged 1 commit into
mainfrom
patschmittdev-brochure-link-spacing

Conversation

@patschmittdev

Copy link
Copy Markdown
Owner

Summary

Astro removed newline/indentation whitespace immediately before three inline anchors in site/src/pages/index.astro. The production DOM contained Clone therepository, then theattack-control mapping, and and theguarantees and residual risks. Add explicit {' '} at those three boundaries, preserving commas, the final period, navigation/flex spacing, layout, and palette. No CSS changes.

Audit all six homepage prose anchors with DOM Range assertions before and after each link, including the already-correct provenance, overview, and project-status links. The regression runs in the existing visual suite and catches joined text regardless of CSS spacing or axe results. Screenshots now use Playwright's output directory so artifacts can remain outside the checkout. A validated decimal PORT override selects the same loopback port as the static server; occupied ports fail instead of silently reusing another worktree's server.

Qualify one consequential claim: a missing signer is not OS-enforced private-key isolation. The homepage now explicitly makes custody outside the vault and access restrictions for the model/Ziggurat process an operator responsibility. AdmissionFigure uses the corresponding imperative rather than implying automatic isolation. Other wording and historical measurement caveats are unchanged.

Trust-boundary impact

None to runtime behavior, contracts, signing bytes, admission, or retrieval. This is a presentation correction and test isolation change.

Focused claim trace uses final integrated main a8e3606d1820ee90ae8e6aea0a993ccb5b29eaef, including #19, #18, #20, and #21:

  • Strict model draft v1, host materialization/staging of Silver v2, and live evidence checks remain in src/contracts/refinement-draft.ts and src/refine/.
  • Bronze remains CRLF-only canonical text; shared parsing now aligns duplicate detection and verification. Gold uses signed canonical line endings, while conditional source_body_sha256 retains live staleness detection without becoming receipt authority.
  • Gold still requires the external Ed25519 receipt plus every eligibility check. Three physically separate profiles, Gold-only read-only MCP, and reference/none output labels remain unchanged.
  • Human CLI display escaping does not change decoded JSON values. Loopback adapter limits and lack of a shipped signer remain unchanged.

The custody qualification was the only substantive homepage mismatch identified in this scoped trace. This is not a comprehensive correctness/security certification, proof of human attention or semantic truth, or production-readiness claim. Source-only/pre-1.0 status remains explicit. Existing measurements are bounded historical development evidence; this PR does not re-benchmark the updated runtime.

Validation

  • Confirmed the new DOM regression fails on the unfixed production build for all three missing-space locations.
  • npm run site:check: passes; zero Astro diagnostics, 7 plugin tests, 24 built pages and link/asset validation.
  • npm run visual -- --grep 'homepage inline prose link boundaries| / visual and accessibility' --output <external-artifact-directory> from site, with PORT=4339: 12 passed, desktop/tablet/mobile in light/dark. Includes text boundaries, custody wording, layout thresholds, and axe.
  • Inspected bounded desktop/mobile light/dark screenshots and readable evaluation/custody crops. This is a focused local inspection, not independent human visual signoff.
  • Port probes: 7 invalid values rejected, 3 valid values discover all six text cases, occupied port explicitly refused.
  • npm run check: 728 passed, 3 platform skips in the 731-test runtime suite; 11 script tests passed; documentation links and style passed.
  • node dist/src/cli/main.js check --root . --audit-clean-room: PASS, no findings.
  • git diff --check: passes. Screenshots/logs are outside the checkout; no dependency, runtime, or CSS changes.

This PR requires the normal independent review and required CI. It is not covered by the one-time exception for the four preceding PRs and must not be merged under that exception.

Checklist

  • Behavior changes include tests that use real temporary files.
  • Model pathways still cannot write Bronze, knowledge, trust, receipts, reviewed metadata, or indexes.
  • No signer, apply, approve, promote command, or --promote flag was added.
  • Retrieved content remains reference-only with instruction_authority: none.
  • Documentation and compatibility notes match the implementation.
  • npm run check passes.
  • node dist/src/cli/main.js check --root . --audit-clean-room passes.
  • No private key, credential, personal path, or private vault content is included.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved blocking issues were identified.

Pull request overview

Fixes homepage inline-link spacing, clarifies external key custody responsibilities, and improves visual-test isolation.

Changes:

  • Adds explicit spacing and DOM regression coverage.
  • Clarifies operator responsibility for key custody.
  • Validates ports and isolates test artifacts.
File summaries
File Reviewed changes
site/tests/visual.spec.ts Adds link-boundary and wording regression tests.
site/src/pages/index.astro Fixes prose spacing and custody wording.
site/src/components/AdmissionFigure.astro Updates custody guidance.
site/playwright.config.ts Validates ports and prevents stale server reuse.
Review details
  • Files reviewed: 4/4 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@patschmittdev
patschmittdev merged commit a310af8 into main Sep 12, 2026
8 checks passed
@patschmittdev
patschmittdev deleted the patschmittdev-brochure-link-spacing branch September 12, 2026 20:08
patschmittdev added a commit that referenced this pull request Sep 12, 2026
## Summary

Update only the current main-policy section in
`docs/release-checklist.md` to match the owner's permanent
solo-development policy authorized on 2026-09-12:

- Pull requests remain required, with zero required approving reviews
and no last-push approval requirement.
- Explicitly state that GitHub does not enforce two-person review under
this policy.
- Retain all seven Actions-bound strict up-to-date CI checks,
administrator enforcement, stale-review dismissal when reviews exist,
linear history, conversation resolution, and force-push/deletion
prohibitions.

The live policy was read back before this documentation change. This PR
makes no GitHub settings changes. It starts from main
`a310af8c3015e78aef059cad5fb3d8596cf4a8eb`; the previously reviewed #22
branch remains at `3b1e7d5b07673813cf09b0c94ac12879d6732405`.

## Trust-boundary impact

None. This is repository development-policy documentation, not a change
to external human-key custody, runtime Gold admission, model authority,
or retrieval behavior.

## Validation

- `npm run check` passes, including documentation links and style.
- `node dist/src/cli/main.js check --root . --audit-clean-room` passes
with no findings.
- `git diff --check` passes.
- The diff is limited to one policy section in one Markdown file.
- Merge only through the normal protected path after all required CI
passes; no administrator or CI bypass.

## Checklist

- [x] Behavior changes include tests that use real temporary files. (No
runtime behavior change.)
- [x] Model pathways still cannot write Bronze, knowledge, trust,
receipts, reviewed metadata, or indexes.
- [x] No signer, apply, approve, promote command, or `--promote` flag
was added.
- [x] Retrieved content remains reference-only with
`instruction_authority: none`.
- [x] Documentation and compatibility notes match the implementation.
- [x] `npm run check` passes.
- [x] `node dist/src/cli/main.js check --root . --audit-clean-room`
passes.
- [x] No private key, credential, personal path, or private vault
content is included.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants