feat(ResponseActions): added opt-in for hiding actions until interaction#806
Conversation
| // We want to append the tooltip inline so that hovering the tooltip keeps the actions container visible | ||
| // when showActionsOnInteraction is true. Otherwise hovering the tooltip causes the actions container | ||
| // to disappear but the tooltip will remain visible. | ||
| const getTooltipContainer = (): HTMLElement => { |
There was a problem hiding this comment.
Just to call this out: if we want to for now we could remove this logic and just deal with the visual oddity that occurs, as Gemini has this exact behavior when you try hovering a message action and then hover over the action tooltip (action isn't visible, but the tooltip remains)
|
Preview: https://chatbot-pr-chatbot-806.surge.sh A11y report: https://chatbot-pr-chatbot-806-a11y.surge.sh |
|
|
||
| &:hover .pf-m-visible-interaction, | ||
| .pf-m-visible-interaction:focus-within { | ||
| opacity: 1; |
There was a problem hiding this comment.
Do we want any sort of transition token to allow this to fade in/out or anything like that?
There was a problem hiding this comment.
Yeah! let use pf-t--global--motion--duration--fade--short
|
this looks good! actually we could try this token instead for the animation pf-t--global--motion--duration--icon--short also not sure if it needs a timing function paired with a fade so you could try this pf-t--global--motion--timing-function--default |
fcb4fa7 to
ae49f0e
Compare
|
I think a small note about this would be handy! I also tweaked a couple of things in the existing example description to just make myself happier, which led to this suggestion (if you like it too):
|
ae49f0e to
e990e3f
Compare
|
🎉 This PR is included in version 6.6.0-prerelease.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
closes #792
Updated the message actions example to include a Message that has this feature