feat(CC-batch-8): added batch 8 by mattnolting · Pull Request #11870 · patternfly/patternfly-react

mattnolting · 2025-06-12T23:40:39Z

Relates to: #11624

Included components:

Component tracker

Figma preview

Resources:

Getting started

patternfly-build · 2025-06-12T23:45:07Z

Preview: https://patternfly-react-pr-11870.surge.sh

A11y report: https://patternfly-react-pr-11870-a11y.surge.sh

Preview: https://pf-react-pr-11870.surge.sh

A11y report: https://pf-react-pr-11870-a11y.surge.sh

evwilkin · 2025-06-26T20:08:21Z

+    props: {
+      // boolean
+      isInputVisible: figma.boolean('Value input'),
+      minmaxValues: figma.boolean('Min/max values'),


I don't see "Min/max values" in Figma. This maps below to the showBoundaries prop, the logic makes sense but maybe this has been removed from Figma and should be removed here as well?

kmcfaul · 2025-09-09T17:51:07Z

+      timeFormat: figma.enum('Format', {
+        'Without time': undefined,
+        Abbreviated: 'short',
+        Numeric: 'numeric'


numeric isn't a value of timeFormat in the props.

timeFormat allows the values: full, long, medium, short.

kmcfaul · 2025-09-09T17:51:54Z

+        'Without time': 'medium',
+        'Without day': undefined,
+        Abbreviated: 'short',
+        Numeric: 'numeric'


Same as timeFormat, numeric isn't a value. The values are the same as timeFormat: full, medium, long, short.

kmcfaul · 2025-09-09T17:52:38Z

+        date={props.defaultTimestampContent}
+        timeFormat={props.timeFormat}
+        dateFormat={props.dateFormat}
+        dateContent={props.dateFormat}


dateContent isn't a prop of Timestamp.

kmcfaul · 2025-09-09T17:54:09Z

+  {
+    props: {
+      // enum
+      size: figma.enum('Size', {


Should be passed as isCompact to the component.

kmcfaul · 2025-09-09T17:54:44Z

+      }),
+
+      // nested props
+      leftItem: figma.nestedProps('Base components/Toggle groups parts', {


I don't know what leftItem, middleItem1, middleItem2, rightItem represent here. Do they need to be defined when children already exists?

Co-authored-by: Evan <evan.wilkinson@gmail.com>

nicolethoen · 2025-10-09T16:04:41Z

+    <Tab
+      eventKey={0}
+      isDisabled={props.isDisabled}
+      actions={props.popover}


This will not work - actions need to be wrapped in a component and the button in the TabAction needs to be referenced in a popover. for now, I think the value of popover should be:

popover: figma.boolean('Help button', { true: ( <TabAction aria-label={`Close tab`} onClick={() => {}} > <TimesIcon /> </TabAction> ), false: undefined })

nicolethoen · 2025-10-09T16:05:13Z

+    <Tab
+      eventKey={0}
+      isDisabled={props.isDisabled}
+      actions={props.popover}


same - if the only thing being passed to the actions component is a popover, nothing will render

nicolethoen · 2025-10-09T16:06:09Z

+  {
+    props: {
+      // string
+      defaultTimestampContent: figma.string('✏️ Default timestamp content'),


This is not being used by anything

nicolethoen · 2025-10-09T16:08:26Z

+      // enum
+      date: figma.enum('Format', {
+        Default: figma.string('✏️ Default timestamp content'),
+        'Without time': figma.string('✏️ Without time'),


These strings with emojis are not doing anything to update the timestamp value. I think each of these values have a different set of props they should be updating in the timestamp component to update the format of the rendered component.

github-actions · 2025-12-14T11:39:26Z

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

evwilkin · 2026-04-10T14:42:45Z

Closed per discussion due to new AI tooling which relieves the maintenance and tech debt that Code Connect manual files introduce.

mattnolting requested review from evwilkin, kmcfaul and nicolethoen June 13, 2025 04:42

mattnolting marked this pull request as draft June 17, 2025 14:54

mattnolting marked this pull request as ready for review June 24, 2025 15:22

evwilkin reviewed Jun 26, 2025

View reviewed changes

Comment thread packages/code-connect/components/Slider/Slider.figma.tsx Outdated

evwilkin reviewed Jun 26, 2025

View reviewed changes

Comment thread packages/code-connect/components/Slider/Slider.figma.tsx Outdated

evwilkin reviewed Jun 26, 2025

View reviewed changes

Comment thread packages/code-connect/components/Slider/Slider.figma.tsx Outdated

evwilkin reviewed Jun 26, 2025

View reviewed changes

Comment thread packages/code-connect/components/Slider/Slider.figma.tsx Outdated

mattnolting force-pushed the feat-CC-batch-8 branch from 9dea0f2 to c2efe09 Compare June 30, 2025 20:38

mattnolting force-pushed the feat-CC-batch-8 branch 3 times, most recently from 0d1081f to 616400f Compare July 31, 2025 19:33

mattnolting force-pushed the feat-CC-batch-8 branch from 616400f to c8ff41f Compare September 4, 2025 15:41

kmcfaul reviewed Sep 9, 2025

View reviewed changes

mattnolting force-pushed the feat-CC-batch-8 branch 2 times, most recently from 4981f61 to ad4eb74 Compare September 16, 2025 20:04

mattnolting force-pushed the feat-CC-batch-8 branch from ad4eb74 to 6d6d202 Compare September 26, 2025 12:28

mattnolting and others added 10 commits September 29, 2025 13:17

feat(CC-batch-8): added batch 8 files

9ac5ac9

feat(CC-batch-8): updated required props

9c68b4c

feat(CC-batch-8): verification complete

d54ca0f

Update packages/code-connect/components/Slider/Slider.figma.tsx

44d931c

Co-authored-by: Evan <evan.wilkinson@gmail.com>

Update packages/code-connect/components/Slider/Slider.figma.tsx

d73faf6

Co-authored-by: Evan <evan.wilkinson@gmail.com>

Update packages/code-connect/components/Slider/Slider.figma.tsx

59e100c

Co-authored-by: Evan <evan.wilkinson@gmail.com>

Update packages/code-connect/components/Slider/Slider.figma.tsx

74afc30

Co-authored-by: Evan <evan.wilkinson@gmail.com>

feat(CC-batch-8): removed splitter

45d877c

feat(CC-batch-8): review-athon round 1 followup

a527eaf

feat(CC-batch-8): group review 6 followup

c6424ad

mattnolting added 3 commits September 29, 2025 13:17

feat(CC-batch-8): refactored toggle-group

3d8253a

feat(CC-batch-8): group review 9/23 updates

0dbd0a7

feat(CC-batch-8): new tabs sub-component files

eb6bc49

mattnolting force-pushed the feat-CC-batch-8 branch from 6d6d202 to eb6bc49 Compare September 29, 2025 17:17

feat(CC-batch-8): cleanup unused imports, organized code

cdf84ba

nicolethoen requested changes Oct 9, 2025

View reviewed changes

github-actions bot added the Stale label Dec 14, 2025

evwilkin closed this Apr 10, 2026

Conversation

mattnolting commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

patternfly-build commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 14, 2025

Uh oh!

evwilkin commented Apr 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mattnolting commented Jun 12, 2025 •

edited

Loading

patternfly-build commented Jun 12, 2025 •

edited

Loading