fix(DrawerPanelContent): fix issue with styles overriding#12039
Merged
thatblindgeye merged 2 commits intopatternfly:mainfrom Oct 21, 2025
Merged
Conversation
Signed-off-by: gitdallas <5322142+gitdallas@users.noreply.github.com>
Collaborator
|
Preview: https://pf-react-pr-12039.surge.sh A11y report: https://pf-react-pr-12039-a11y.surge.sh |
wise-king-sullyman
approved these changes
Oct 8, 2025
gitdallas
requested review from
a team,
mcoker and
rebeccaalpert
and removed request for
a team
Contributor
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
Can we just add a couple tests that checks a) the style prop is applied as expected and b) it can override the existing boundaryCssVars?
Signed-off-by: gitdallas <5322142+gitdallas@users.noreply.github.com>
thatblindgeye
approved these changes
Oct 15, 2025
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11821
example with both maxSize and backgroundColor style applied:
