chore(docs): Update ModalWithDropdown example#12061
Merged
dlabaj merged 3 commits intopatternfly:mainfrom Oct 21, 2025
Merged
Conversation
rebeccaalpert
force-pushed
the
dropdown-focus
branch
from
1c94720 to
bd0895f
Compare
Collaborator
|
Preview: https://pf-react-pr-12061.surge.sh A11y report: https://pf-react-pr-12061-a11y.surge.sh |
rebeccaalpert
requested review from
a team,
dlabaj and
nicolethoen
and removed request for
a team
Example was using out-of-date PatternFly syntax from a prior version. It should now show how to properly add a dropdown to a modal that allows for keyboard accessibility.
rebeccaalpert
force-pushed
the
dropdown-focus
branch
from
bd0895f to
73868fb
Compare
Contributor
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
This looks good to me, some comments below that would probably be worth discussing/implementing, just because I believe consumers have raised issue with menus inside Modal's causing a scrollbar so it'd be good for us to convey how to avoid that with this example update.
rebeccaalpert
force-pushed
the
dropdown-focus
branch
from
43558a8 to
bca47fb
Compare
thatblindgeye
requested changes
Oct 17, 2025
thatblindgeye
approved these changes
Oct 20, 2025
dlabaj
approved these changes
Oct 21, 2025
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example was using out-of-date PatternFly syntax from a prior version. It should now show how to properly add a dropdown to a modal that allows for keyboard accessibility.
What: Closes #11847
Additional issues: