feat(Button): added circle variant#12092
Merged
wise-king-sullyman merged 7 commits intopatternfly:mainfrom Oct 28, 2025
Merged
Conversation
Collaborator
|
Preview: https://pf-react-pr-12092.surge.sh A11y report: https://pf-react-pr-12092-a11y.surge.sh |
thatblindgeye
force-pushed
the
iss12081_circleButton
branch
from
55fbc22 to
b0e77d6
Compare
kmcfaul
approved these changes
Oct 27, 2025
Contributor
kmcfaul
left a comment
kmcfaul
left a comment
There was a problem hiding this comment.
react implementation lgtm
thatblindgeye
force-pushed
the
iss12081_circleButton
branch
from
b0e77d6 to
3ed562b
Compare
kmcfaul
approved these changes
Oct 27, 2025
Contributor
kmcfaul
left a comment
kmcfaul
left a comment
There was a problem hiding this comment.
LGTM, just needs the prop on one of the example buttons
| icon={<BellIcon />} | ||
| aria-label="Stateful attention circle variant example" | ||
| /> | ||
| <Button |
Contributor
There was a problem hiding this comment.
Needs isCircle on this one.
kmcfaul
approved these changes
Oct 27, 2025
wise-king-sullyman
approved these changes
Oct 28, 2025
thatblindgeye
force-pushed
the
iss12081_circleButton
branch
from
28da3bd to
25c23b0
Compare
wise-king-sullyman
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #12081
Needs to wait on patternfly/patternfly#7922 getting merged in order to pull in styles/class
Additional issues: