feat(drawer): add no-glass panel variant, test#12125
feat(drawer): add no-glass panel variant, test#12125kmcfaul merged 3 commits intopatternfly:mainfrom
Conversation
|
Preview: https://pf-react-pr-12125.surge.sh A11y report: https://pf-react-pr-12125-a11y.surge.sh |
| hasNoBorder?: boolean; | ||
| /** Flag indicating that the drawer panel should be resizable. */ | ||
| isResizable?: boolean; | ||
| /** Flag indicating that the drawer panel should disable glass styles. **Note:** only applies to drawers with `isPill`. */ |
There was a problem hiding this comment.
I know I just approved this, but do we want beta on here? Also want to note that prop descriptions do not render as markdown.
There was a problem hiding this comment.
Thanks! I was on autopilot, this is how we write them in core. Updated!
|
Test is failing because this modifiers object in this file doesn't have the no-glass attribute yet:
I hit this when I didn't have the right version of Core before. |
Doh! I forgot to add the |
|
I didn't notice, so XD |
4 participants
fixes #12121
when glass theme is enabled (
<html class="pf-v6-theme-glass">), a pill drawer will have glass styles by default.hasNoGlasswill remove those glass styles via.pf-m-no-glass. I'm applying the glass any timehasNoGlassis applied, not just ifisPillis true. Let me know if you'd like me to only apply.pf-m-no-glassifisPillis true.