feat(Compass): add compass nav components#12138
Conversation
|
Preview: https://pf-react-pr-12138.surge.sh A11y report: https://pf-react-pr-12138-a11y.surge.sh |
wise-king-sullyman
requested review from
kmcfaul,
srambach and
thatblindgeye
| <div | ||
| style="display: contents;" | ||
| > |
There was a problem hiding this comment.
Is it expected to get this extra div around the search contents? It's here and on the nav-home also
There was a problem hiding this comment.
Yeah that's coming from the Tooltip
There was a problem hiding this comment.
Do we want to update the internal tooltips to use triggerRef to avoid this styled wrapping div? I know we've tried to avoid that div in most places but it was breaking to do that for Tooltip at the time iirc.
There was a problem hiding this comment.
I'm not opposed to that
| <div | ||
| style="display: contents;" | ||
| > |
| <div | ||
| style="display: contents;" | ||
| > |
There was a problem hiding this comment.
Do we want to update the internal tooltips to use triggerRef to avoid this styled wrapping div? I know we've tried to avoid that div in most places but it was breaking to do that for Tooltip at the time iirc.
Co-authored-by: kmcfaul <45077788+kmcfaul@users.noreply.github.com>
Co-authored-by: kmcfaul <45077788+kmcfaul@users.noreply.github.com>
Co-authored-by: kmcfaul <45077788+kmcfaul@users.noreply.github.com>
Co-authored-by: kmcfaul <45077788+kmcfaul@users.noreply.github.com>
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
Really just a nit, but could we have the Home tooltip default to the left, but update when necessary?
Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com>
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
5 participants
Closes #12116
Convenience link to the updated demo: https://pf-react-pr-12138.surge.sh/patternfly-ai/generative-uis/compass/react/demo/