feat(react-icons): add rhds icons#12143
Merged
nicolethoen merged 8 commits intopatternfly:mainfrom Nov 20, 2025
Merged
Conversation
634ce87 to
26b3489
Compare
Collaborator
|
Preview: https://pf-react-pr-12143.surge.sh A11y report: https://pf-react-pr-12143-a11y.surge.sh |
2cad9a8 to
89fe4e3
Compare
89fe4e3 to
c1b9595
Compare
03c6613 to
5a8e92d
Compare
Contributor
Author
|
@kmcfaul @nicolethoen do you know why the build is failing? I tried clearing the gh action cache. It all works locally - the react repo builds and running |
Contributor
|
I'll take a look at it in a bit - for our reference, this is the error i'm seeing in the logs: |
4f1e75c to
5952764
Compare
andrew-ronaldson
approved these changes
Nov 19, 2025
Collaborator
andrew-ronaldson
left a comment
There was a problem hiding this comment.
Looks good. Future us will want to add a filter and/or search to this page.
nicolethoen
approved these changes
Nov 19, 2025
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
This was referenced Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #12144
You can see them on https://pf-react-pr-12143.surge.sh/icons by looking for "rhds"
@rhds/iconspackage<path d="{this}">) out of the rhds icons and adds them in JSON toscripts/icons/rhdsIcons[type].mjsfor each of the icon types. The key for each icon is in the format of "rhds-[type]-[icon name]".prettierignoreand added these files to it. I dunno if there's a better/different way to handle that?Right now you need to run
node scripts/parseRHDSIcons.mjsto generate new icons if there is a new version of@rhds/icons. Is that preferred or would we want it to run automatically somehow?Assisted-by: Compass