feat(react-icons): update to create static SVGs#12154
Merged
dlabaj merged 6 commits intopatternfly:mainfrom Dec 3, 2025
Merged
feat(react-icons): update to create static SVGs#12154dlabaj merged 6 commits intopatternfly:mainfrom
dlabaj merged 6 commits intopatternfly:mainfrom
Conversation
Collaborator
|
Preview: https://pf-react-pr-12154.surge.sh A11y report: https://pf-react-pr-12154-a11y.surge.sh |
kmcfaul
approved these changes
Dec 2, 2025
Contributor
kmcfaul
left a comment
There was a problem hiding this comment.
I think this looks great! I don't think the added dir to the icons build should make too much of a difference because it should tree shake out unused icons if I understand that process correctly (or users would import directly from the dist).
dlabaj
approved these changes
Dec 3, 2025
Contributor
dlabaj
left a comment
There was a problem hiding this comment.
I think the size is okay since it's 11mb and people can always just import what they need.
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #12153
A couple of thoughts