feat(Toolbar): dynamic sticky #12375
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| import { useLayoutEffect, useState, useRef } from 'react'; | ||
| import { Toolbar, ToolbarItem, ToolbarContent, SearchInput, Checkbox } from '@patternfly/react-core'; | ||
|
|
||
| const useIsStuckFromScrollParent = ({ | ||
| shouldTrack, | ||
| scrollParentRef | ||
| }: { | ||
| /** Indicates whether to track the scroll top position of the scroll parent element */ | ||
| shouldTrack: boolean; | ||
| /** Reference to the scroll parent element */ | ||
| scrollParentRef: React.RefObject<any>; | ||
| }): boolean => { | ||
| const [isStuck, setIsStuck] = useState(false); | ||
|
|
||
| useLayoutEffect(() => { | ||
| if (!shouldTrack) { | ||
| setIsStuck(false); | ||
| return; | ||
| } | ||
|
|
||
| const scrollElement = scrollParentRef.current; | ||
| if (!scrollElement) { | ||
| setIsStuck(false); | ||
| return; | ||
| } | ||
|
|
||
| const syncFromScroll = () => { | ||
| setIsStuck(scrollElement.scrollTop > 0); | ||
| }; | ||
| syncFromScroll(); | ||
| scrollElement.addEventListener('scroll', syncFromScroll, { passive: true }); | ||
| return () => scrollElement.removeEventListener('scroll', syncFromScroll); | ||
| }, [shouldTrack, scrollParentRef]); | ||
|
|
||
| return isStuck; | ||
| }; | ||
|
|
||
| export const ToolbarDynamicSticky = () => { | ||
| const scrollParentRef = useRef<HTMLDivElement>(null); | ||
| const isStickyStuck = useIsStuckFromScrollParent({ shouldTrack: true, scrollParentRef }); | ||
| const [showEvenOnly, setShowEvenOnly] = useState(true); | ||
| const [searchValue, setSearchValue] = useState(''); | ||
| const array = Array.from(Array(30), (_, x) => x); // create array of numbers from 1-30 for demo purposes | ||
| const numbers = showEvenOnly ? array.filter((number) => number % 2 === 0) : array; | ||
|
kmcfaul marked this conversation as resolved.
Comment on lines
+42
to
+44
There was a problem hiding this comment.
The 🐛 Proposed fix- const numbers = showEvenOnly ? array.filter((number) => number % 2 === 0) : array;
+ const filteredByEven = showEvenOnly ? array.filter((number) => number % 2 === 0) : array;
+ const numbers = searchValue
+ ? filteredByEven.filter((number) => `item ${number}`.includes(searchValue))
+ : filteredByEven;Also applies to: 51-56, 69-71 🤖 Prompt for AI Agents |
||
|
|
||
| return ( | ||
| <div id="dynamic-sticky-scroll-parent" ref={scrollParentRef} style={{ overflowY: 'scroll', height: '200px' }}> | ||
| <Toolbar id="toolbar-sticky" inset={{ default: 'insetNone' }} isStickyBase isStickyStuck={isStickyStuck}> | ||
| <ToolbarContent> | ||
| <ToolbarItem> | ||
| <SearchInput | ||
| aria-label="Sticky example search input" | ||
| value={searchValue} | ||
| onChange={(_event, value) => setSearchValue(value)} | ||
| onClear={() => setSearchValue('')} | ||
| /> | ||
| </ToolbarItem> | ||
| <ToolbarItem alignSelf="center"> | ||
| <Checkbox | ||
| label="Show only even number items" | ||
| isChecked={showEvenOnly} | ||
| onChange={(_event, checked) => setShowEvenOnly(checked)} | ||
| id="showOnlyEvenCheckbox" | ||
| /> | ||
| </ToolbarItem> | ||
| </ToolbarContent> | ||
| </Toolbar> | ||
| <ul> | ||
| {numbers.map((number) => ( | ||
| <li key={number}>{`item ${number}`}</li> | ||
| ))} | ||
| </ul> | ||
| </div> | ||
| ); | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.