feat(Drawer): Add full-size drawer - #12641
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (8)
🚧 Files skipped from review as they are similar to previous changes (4)
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review. WalkthroughThe Drawer component adds the beta ChangesDrawer viewport support
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant Page
participant Drawer
participant DrawerPanelContent
participant User
Page->>Drawer: renders viewport Drawer
Drawer->>DrawerPanelContent: provides isViewport and refs
User->>DrawerPanelContent: resizes panel
DrawerPanelContent->>Drawer: measures viewport drawer reference
User->>Drawer: closes drawer
Merge Risk: ⚪ Minimal · up to The Drawer viewport support, optional content handling, resizing safeguards, tests, and example are aligned with the stated feature behavior. No actionable merge risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
7a5801e to
605a877
Compare
Use isViewport and place drawer below Page to achieve a full-height drawer that allows Page content to scroll behind it. Fixes patternfly#12635
605a877 to
0cbcbce
Compare
Use isViewport and place drawer below Page to achieve a full-height drawer that allows Page content to scroll behind it.
Fixes #12635
Summary by CodeRabbit
New Features
Bug Fixes
Documentation