-
Notifications
You must be signed in to change notification settings - Fork 392
feat(Page): add PageFooter and isPlain #12642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kmcfaul
wants to merge
4
commits into
patternfly:main
Choose a base branch
from
kmcfaul:page-separate-header
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| import styles from '@patternfly/react-styles/css/components/Page/page'; | ||
| import { css } from '@patternfly/react-styles'; | ||
|
|
||
| export interface PageFooterProps extends React.HTMLProps<HTMLElement> { | ||
| /** Content rendered inside the footer */ | ||
| children?: React.ReactNode; | ||
| /** Additional classes added to the footer */ | ||
| className?: string; | ||
| /** Sets the base component to render. Defaults to footer */ | ||
| component?: keyof React.JSX.IntrinsicElements; | ||
| } | ||
|
|
||
| export const PageFooter: React.FunctionComponent<PageFooterProps> = ({ | ||
| className, | ||
| children, | ||
| component = 'footer', | ||
| ...props | ||
| }: PageFooterProps) => { | ||
| const Component = component as any; | ||
|
|
||
| return ( | ||
| <Component {...props} className={css(styles.pageFooter, className)}> | ||
| {children} | ||
| </Component> | ||
| ); | ||
| }; | ||
|
|
||
| PageFooter.displayName = 'PageFooter'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 changes: 38 additions & 0 deletions
38
packages/react-core/src/components/Page/__tests__/PageFooter.test.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| import { render, screen } from '@testing-library/react'; | ||
| import styles from '@patternfly/react-styles/css/components/Page/page'; | ||
| import { PageFooter } from '../PageFooter'; | ||
|
|
||
| test('Renders children', () => { | ||
| render(<PageFooter>Footer content</PageFooter>); | ||
| expect(screen.getByRole('contentinfo')).toBeVisible(); | ||
| }); | ||
|
|
||
| test('Renders without children', () => { | ||
| render(<PageFooter data-testid="footer" />); | ||
| expect(screen.getByTestId('footer')).toBeVisible(); | ||
| }); | ||
|
|
||
| test(`Renders with class ${styles.pageFooter} by default`, () => { | ||
| render(<PageFooter>Footer content</PageFooter>); | ||
| expect(screen.getByRole('contentinfo')).toHaveClass(styles.pageFooter, { exact: true }); | ||
| }); | ||
|
|
||
| test('Renders as a footer by default', () => { | ||
| render(<PageFooter>Footer content</PageFooter>); | ||
| expect(screen.getByRole('contentinfo').tagName).toBe('FOOTER'); | ||
| }); | ||
|
|
||
| test('Renders as a custom component when component is passed', () => { | ||
| render(<PageFooter component="div">Footer content</PageFooter>); | ||
| expect(screen.getByText('Footer content').tagName).toBe('DIV'); | ||
| }); | ||
|
|
||
| test('Renders with custom classes when className is passed', () => { | ||
| render(<PageFooter className="custom-class">Footer content</PageFooter>); | ||
| expect(screen.getByRole('contentinfo')).toHaveClass('custom-class'); | ||
| }); | ||
|
|
||
| test('Renders with spread props', () => { | ||
| render(<PageFooter id="custom-id">Footer content</PageFooter>); | ||
| expect(screen.getByRole('contentinfo')).toHaveAttribute('id', 'custom-id'); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 4 additions & 3 deletions
7
...nents/Page/examples/PageHeaderContent.tsx → ...e/examples/PageHeaderAndFooterContent.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also add the "Renders without children" test