feat: show ghost node during node drag#311
Conversation
|
@shivamG640 Looking good. I'd like to get some feedback from @andrew-ronaldson on any suggestions for the ghost node that is left behind so that it is obvious to users that the node left behind is temporary. Also, I don't think we should use the data field |
|
Topology Demo surge: https://show-ghost-node-during-node-drag.surge.sh/ |
shivamG640
force-pushed
the
show-ghost-node-during-node-drag
branch
from
7bf4e6b to
810a339
Compare
jeff-phillips-18
left a comment
jeff-phillips-18
left a comment
There was a problem hiding this comment.
Looking good. A few comments. Thanks @shivamG640
shivamG640
force-pushed
the
show-ghost-node-during-node-drag
branch
from
810a339 to
540b8b0
Compare
|
Thanks for the review @jeff-phillips-18 |
jeff-phillips-18
left a comment
jeff-phillips-18
left a comment
There was a problem hiding this comment.
LGTM. Thanks @shivamG640!
|
@andrew-ronaldson I have updated the surge with the latest changes including your suggestion. PTAL. |
|
@andrew-ronaldson @nicolethoen Please take a look at your earliest convenience. I'd like this PR to get in before any new release as it fixes a problem in DefaultEdge that would be a breaking change if it were to release prior to this releasing. |
|
🎉 This PR is included in version 6.5.0-prerelease.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
4 participants
What
Closes #305
Description
When a node is dragged, its original position becomes empty, causing an awkward empty space between the connected edges.
This PR adds an optional “ghost node” (dummy/static placeholder) at the original position of the dragged node. The ghost node would remain non-interactive, fixed while the real node is being dragged and be removed once the drag operation completes, preserving visual continuity.
Type of change
Screen shots / Gifs for design review
Screencast.From.2026-03-31.21-37-14.mp4
Important Note
This PR also includes a fix in the
DefaultEdgecomponent, removing the data-based approach for retrieving thefreezeEdgeDuringNodeDragvalue.