fix: PatternFly compliance cleanup and component architecture improvements#19
Merged
nicolethoen merged 4 commits intopatternfly:mainfrom Feb 14, 2026
Merged
Conversation
…provements
- Replace CSS-in-JS (styles.ts) with static stylesheet (styles.css)
- Standardize all class names to pf-v6-widget- prefix with BEM modifiers
- Remove PF utility classes, convert to custom CSS with logical properties
- Switch all icon imports to dist/esm individual paths for tree-shaking
- Extract toolbar from WidgetDrawer into WidgetLayout with AddWidgetsButton
- Fix maxH/minH spread-overwrite bug, remove unnecessary Divider
- Replace hardcoded SVG color with currentColor + PF token
- Fix resize handle, drag handle, and dropdown accessibility issues
- Add rel="noopener noreferrer" to target="_blank" links
- Remove anti-pattern tabIndex={index} from grid items
- Rewrite examples with richer PF component content
- Replace WithoutDrawerExample with CustomToolbarExample
- Add transformIgnorePatterns to Jest config for dist/esm imports
- Add build:watch CSS copying via nodemon
- Add test coverage for GridTile actions, WidgetDrawer, AddWidgetsButton
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Update react-grid-layout from ^1.5.1 to ^2.2.2 - Migrate to v2 API: gridConfig, dragConfig, resizeConfig, dropConfig - Replace manual ResizeObserver with useContainerWidth hook - Update type imports: Layout → LayoutItem (from react-grid-layout) - Update callback signatures for readonly arrays and nullable params - Add droppingWidgetType prop for drawer→grid drag coordination - Add onWidgetDragStart/onWidgetDragEnd to WidgetDrawer - Switch tsconfig moduleResolution from "node" to "bundler" - Remove @types/react-grid-layout (types now bundled in v2) - Update @patternfly/patternfly to ^6.5.0-prerelease.33 - Fix pr-preview CI workflow: npm → yarn, corepack setup, surge deploy - Add widget configuration and layout item docs tables Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
🎉 This PR is included in version 1.0.0-prerelease.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the state of the docs before I made the changes (for reference):
Preview of the changes in the docs:
http://widgetized-dashboard-after.surge.sh/extensions/widgetized-dashboard