refactor(cli): extract sanitizeFilename to shared lib/file-utils#187
Merged
Conversation
The same sanitizeFilename implementation lived in both bin/commands/attachments.js and bin/commands/export.js, so any future fix had to be made twice. Move it to lib/file-utils.js and import from both call sites.
|
🎉 This PR is included in version 2.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sanitizeFilenamewas duplicated inbin/commands/attachments.jsandbin/commands/export.js. Bug fixes to one wouldn't propagate to the other.lib/file-utils.jsand import it from both call sites.sanitizeFilenamere-export fromexport.js; updatetests/export.test.jsto import from the new module.Test plan
npm test— 682 tests passnpm run lint— clean