refactor(fx): consume the shared backend rate policy — FX-only cutover to main - #2646
Conversation
… onto main) The FX half of #2607 replayed onto main on its own. dev also carries the support-reply badge and a websocket log fix; neither belongs in an FX-only cutover, so they stay on dev for the next release. Clean because FX barely touches shared code — proxy.ts, api-fetch.ts, sentry.utils.ts and demo-api.ts differ from main on FX lines only, and no badge file is touched. api.openapi.json is the FX-hotfix backend's spec, with api.generated.ts regenerated from it: /fx/rate and the badge paths are both present. MUST deploy AFTER peanut-api-ts hotfix/fx-shared-rate-api. This drops api.frankfurter.app from CSP, so shipping the FE while /fx/* is absent from prod blanks every rate surface with no fallback path.
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 5 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (19)
Comment |
🧪 UI test report — ✅ all greenSuites
📊 Coverage (unit)
⏱ 10 slowest test cases
|
Code-analysis diffPainscore total: 7127.92 → 7126.24 (-1.68) 🆕 New findings (380)
…and 360 more. ✅ Resolved (380)
…and 360 more. 📈 Painscore deltas (top movers)
|
FX only. The FX half of #2607 replayed onto
main.devalso carries the support-reply badge and a websocket log fix; neither belongs in an FX-only cutover, so they stay for the next release.Pairs with peanut-api-ts #1312.
peanut-api-ts #1312 must be merged and deployed first. This PR drops
api.frankfurter.appfrom CSP, so if the FE ships while/fx/*is absent from prod, every rate surface blanks and the old path cannot be hot-restored.Why the cutover is clean
proxy.ts,api-fetch.ts,sentry.utils.tsanddemo-api.tsdiffer frommainon FX lines only. No badge file is touched.api.openapi.jsonis the FX-hotfix backend's spec andapi.generated.tswas regenerated from it —/fx/rateand the badge paths are both present, rather than hand-merged.What it fixes
503added to the Sentry skip list for/fx/rate— peanut-api already reports the upstream cause; reporting it client-side multiplies one incident by every mounted hook and its retries./fx/rategets a real demo-api handler; without one a failed passthrough answered200 {}.Verification
Typecheck clean, 2873 tests green. FX behaviour verified on staging as part of
dev: 43/43 on the backend shadow-compare.