fix(landing): localize the injected supported-rails FAQ and anchor it by id - #2700
Conversation
… by id Two locale bugs in the code-injected rails FAQ on /es-419, /es-ar, /pt-br: the insert anchored on the English question text (/what is peanut/i), so on localized pages it fell to the end of the list, and the question/answer were English constants, leaving one English FAQ inside translated pages (visible live today, also in the FAQPage JSON-LD). Anchor by FAQ id instead (content files keep ids aligned across locales) and move the question + answer sentence templates into the marketing i18n catalogs; the fact lists (chains, rails) still interpolate from rhino.consts so the answer can't drift from what the app supports. Known follow-up: FIAT_RAILS region labels still render in English inside the localized answer. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Code-analysis diffPainscore total: 7158.71 → 7159.84 (+1.13) 🆕 New findings (3)
✅ Resolved (3)
📈 Painscore deltas (top movers)
|
🧪 UI test report — ✅ all greenSuites
📊 Coverage (unit)
⏱ 10 slowest test cases
|
Problem
Two locale bugs in the code-injected "Which networks, tokens and banks…" FAQ on the localized landings (
/es-419,/es-ar,/pt-br), both visible on prod today:withSupportedRailsanchored the insert on the English question text (/what is peanut\??/i), so on localized pages the rails FAQ falls to the end of the list instead of slotting after "¿Qué es Peanut?" / "O que é o Peanut?".Fix
'1') — thecontent/landing/{locale}.mdfiles keep FAQ ids aligned across locales by design.landingSupportedRailsFaqQuestion/landingSupportedRailsFaqAnswer/listJoinAnd), interpolated via the existingt()helper. The fact lists (EVM chains, other chains, fiat rails) still derive fromrhino.consts, so the public answer can't drift from what the app supports.Verification
jest src/i18n— 117 tests green (incl. key-parity + placeholder-parity across locales).tsc --noEmit: 231 pre-existing TS2307 module-resolution errors in this worktree (uninitializedsrc/contentsubmodule / asset stubs), zero in changed files, all-TS2307 histogram identical in kind to untouched base.Notes
FIAT_RAILSregion labels ("United States", "36 countries", …) still render in English inside the localized answer and in the client chip UI (SupportedRailsFaqAnswer) — localizing those touches the chip component and is left for a separate small PR.🤖 Generated with Claude Code