chore(dev/journey): mirror lifecycle v2 spec — step ladder, win_back, finish_setup removal - #2731
Merged
Conversation
…sh_setup gone Companion to peanut-api-ts#1360, which changed the /__dev/journey-spec shape: rules.stepAfterDays replaces the two fixed step fields (stages now carry 2 or 3 steps), dormancyDays and maxSendsPerDay are new, finish_setup no longer exists, and win_back does. The board maps win_back to the spent column (going quiet for 6 weeks re-enters the machine), the application-in-flight column documents why it is silent by design, and the settled finish_setup kill-or-keep decision flag is retired.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Contributor
Code-analysis diffPainscore total: 7161.25 → 7161.85 (+0.6) 🆕 New findings (1)
✅ Resolved (1)
|
Contributor
🧪 UI test report — ✅ all greenSuites
📊 Coverage (unit)
⏱ 10 slowest test cases
|
Hugo0
marked this pull request as ready for review
August 18, 2026 16:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion to peanutprotocol/peanut-api-ts#1360 (lifecycle machine v2). The
/__dev/journey-specresponse changed shape and the dev journey board must mirror it:SpecRules.stepAfterDays(array) replacesstep1AfterDays/step2AfterDays— stages now carry 2 or 3 steps;RulesLegendmaps over the ladder and shows the newdormancyDaysandmaxSendsPerDayrules.win_backstage mapped to the (renamed) "Spent → dormant" column — going quiet for 6 weeks re-enters the machine.finish_setupremoved: its column documents why the machine is silent there by design; its settled kill-or-keep decision flag is retired.Task
Notion: Activation machine — reach the users it cannot see (Sprint 156)
Risks / breaking changes
Dev-only surface (
/dev/journey); no production UI touched.useJourneySpecdegrades gracefully against an old API, so merge order with api#1360 is not load-bearing — but the board only renders the new rules once both are deployed.QA
Typecheck clean · full suite 3,110 passed (journey suites 24/24) · prettier applied.
Screenshots: N/A (dev-only tooling board; no customer-visible change)