Keep the format check off the mono-owned chip review workflow - #34
Conversation
chip-pr-review.yml landed in 2bac907 as a byte-identical copy of mono's file, and Prettier would reflow it, so the CI format check now fails on every PR. The file can't be reformatted here without drifting from mono, so the check skips it instead.
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chip-peanut-bot[bot]](https://avatars.githubusercontent.com/in/2915219?s=60&v=4){kind=small}
There was a problem hiding this comment.
Chip review — no blocking findings — this is not an approval
No findings. The new ignore entry excludes only the mono-owned workflow from root Prettier formatting.
Checked clean
- Confirmed the pinned head and exact base merge-base; the diff changes only .prettierignore.
- Prettier file-info reports the workflow ignored, and its bytes match the canonical mono copy.
- The CI check job was still running when reviewed; other completed checks were successful or skipped.
Security review: did not run — this change has no security, privacy or money surface, so it was not asked. This review is one reviewer short.
Third opinion by claude-opus: 0 finding(s), marked with the model name. It answers only product truth, missing tests and the cross-repo contract, so treat its findings as advice.
Exact head: 9d63d270b939 · Context: repo, mono · Took 4m
The CI
checkjob fails on every PR since2bac9070. Prettier flags.github/workflows/chip-pr-review.yml([warn] .github/workflows/chip-pr-review.yml … Code style issues found). That file must stay byte-identical to mono'sops/schedulers/pr-review/chip-pr-review.yml, so it can't be reformatted here.This adds only that path to
.prettierignore. The workflow file itself is untouched.Verified: running
prettier --checkon the file with the new ignore reports "All matched files use Prettier code style". chip noted the same failure in its review of #33.🤖 Generated with Claude Code
https://claude.ai/code/session_01BbTFsJ6NvdFt4NG4UJG57m