Draft: fix buildPebbleApp, use new SDK, test reverse dependencies compilation#17
Open
t184256 wants to merge 4 commits into
Open
Draft: fix buildPebbleApp, use new SDK, test reverse dependencies compilation#17t184256 wants to merge 4 commits into
t184256 wants to merge 4 commits into
Conversation
Fixes: pebble-dev#15 Signed-off-by: Alexander Sosedkin <monk@unboiled.info>
Signed-off-by: Alexander Sosedkin <monk@unboiled.info>
Signed-off-by: Alexander Sosedkin <monk@unboiled.info>
Signed-off-by: Alexander Sosedkin <monk@unboiled.info>
Member
|
Yeah, I've definitely gotta go back and look at that function again - been meaning to give it some attention, I've just been more focused on the development setup experience lately. Having some proper tests for it is definitely a good idea though, I'll take a look at this PR when I get around to doing that. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This currently fails in CI with
for reasons that evade me.
I don't insist things should be done this way, treat it more like a list of things that I think should be done for others to use your flake and feel safe doing it: feel free to cherry-pick, amend, etc.