Update to new minify function parameters#8
Closed
Lychrell wants to merge 1 commit into
Closed
Conversation
minify_html had breaking changes since 0.16.0. This should fix it
Lychrell
changed the title
Contributor
|
Hi @Lychrell. Just like in #7, it seems the tests fail because the JS minify function in 0.16 causes a PanicException. Until the upstream issue is resolved, I am inclined to pin the upstream dependency to 0.15 by adding an upper version bound to the dependency specification and release a new version of this plugin as an interim solution. |
justinmayer
changed the title
minify function parameters
Contributor
|
Thanks again for your submission @Lychrell. I merged #7 instead, which should comprehensively address the problem. Fixed version released as Minify 2.0.1 ✨ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
minify_htmlhad breaking changes since 0.16.0. This should fix #6