Address review feedback for no-permit EVM offramp fallback#1134
Closed
Copilot wants to merge 2 commits into
Closed
Address review feedback for no-permit EVM offramp fallback#1134Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
✅ Deploy Preview for vortexfi ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for vortex-sandbox ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
… no-permit messages Agent-Logs-Url: https://github.com/pendulum-chain/vortex/sessions/bb4b3a39-0478-47f2-ab90-2834439c9c34 Co-authored-by: ebma <6690623+ebma@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Create new production release
Address review feedback for no-permit EVM offramp fallback
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes three issues identified in review of the no-permit fallback path for ERC-20 tokens without EIP-2612
permitsupport.nonces() probe error handling: Catch only
ContractFunctionExecutionError(contract revert / function-not-found) when probing permit support. Network/transport errors are now re-thrown so the request fails fast instead of silently switching to the no-permit flow on transient RPC issues.waitForUserHash tx validation: Verify
receipt.frommatchesstate.walletAddressbefore advancing the ramp. Prevents a user from supplying an arbitrary successful tx hash to skip token movement.Dedicated no-permit phase messages: Replace misleading "Initializing/Authorizing transfer..." reuse with accurate messages for
squidRouterNoPermitApprove,squidRouterNoPermitSwap, andsquidRouterNoPermitTransferphases (EN + PT).